Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-design a tad more carefully #12

Closed
ryankurte opened this issue Dec 22, 2020 · 0 comments
Closed

Re-design a tad more carefully #12

ryankurte opened this issue Dec 22, 2020 · 0 comments
Assignees
@ryankurte

Comments

@ryankurte
Copy link
Collaborator

ryankurte commented Dec 22, 2020 •
edited
Loading

Improve the design of this, follow-up from #9

  • Support multiple parallel versions (install binaries with version suffix, update symlink)
  • Avoid tar-explosions / overwriting things
    • Support specifying binaries to be extracted in Cargo.toml
    • Extract to temporary dir, check files are reasonable, ask for confirmation
  • Support non-rust binary installs

And specify the behaviour in a Design section of the readme.
@ryankurte ryankurte self-assigned this Dec 22, 2020
@ryankurte ryankurte mentioned this issue Dec 30, 2020
Merged
ryankurte added a commit that referenced this issue Dec 31, 2020
@ryankurte
Merge pull request #16 from ryankurte/refactor
748e8a2 
Refactor per #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryankurte ryankurte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryankurte