Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stale mocks are not always removed, causing build issues #109

Closed
nikolaykasyanov opened this issue Dec 28, 2021 · 0 comments · Fixed by #118
Closed

Stale mocks are not always removed, causing build issues #109

nikolaykasyanov opened this issue Dec 28, 2021 · 0 comments · Fixed by #118

Comments

@nikolaykasyanov
Copy link
Member

nikolaykasyanov commented Dec 28, 2021 •
edited
Loading

When an interface is removed and an engineer has its generated mock locally, generateMocks task will not wipe it, leading to a build error while trying to compile it.

Example (internal link): https://careemteam.slack.com/archives/CB9STU0FM/p1640688401002300
MarcoSignoretto added a commit that referenced this issue May 13, 2022
@MarcoSignoretto
Clear mocks before regeneration
ffffb09 
This patch fix #109 ensuring older version of the mock is always removed.
@MarcoSignoretto MarcoSignoretto mentioned this issue May 13, 2022
Merged
MarcoSignoretto added a commit that referenced this issue May 18, 2022
@MarcoSignoretto
Clear mocks before regeneration (#118)
554829d 
* Clear mocks before regeneration

This patch fix #109 ensuring older version of the mock is always removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clear mocks before regeneration careem/mockingbird
1 participant
@nikolaykasyanov