Spike / Not merge: Inception chain component #1603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By separating starting of processes from the scenario, we can re-use it better.
Not quite happy with the re-use of functions across scenarios, but this will do.
Obviously there should be more re-use across running on cardano-node and hydra-node
This should allow us to publish the scripts also in a hydra head (query utxo differently etc)
ch1bo
force-pushed
the
inception
branch
2 times, most recently
from
3a4c50e
to
d82053c
Compare
ffakenz
reviewed
Sep 9, 2024
| @@ -192,6 +192,14 @@ postDecommit HydraClient{apiHost = Host{hostname, port}} decommitTx = do | |||
| <&> setRequestBodyJSON decommitTx | |||
| >>= httpLbs | |||
|
|
|||
| -- | Fetch protocol parameters fro a hydra-node. | |||
There was a problem hiding this comment.
Suggested change
| -- | Fetch protocol parameters fro a hydra-node. | |
| -- | Fetch protocol parameters for a hydra-node. |
| withTracerOutputTo h "Inception" $ \tracer -> do | ||
| let l2Dir = tmpDir </> "l2" | ||
| withCardanoNodeDevnet (contramap FromCardanoNode tracer) l2Dir $ \node@RunningNode{networkId} -> do | ||
| hydraScriptsTxId <- publishHydraScriptsAs node Faucet |
There was a problem hiding this comment.
Suggested change
| hydraScriptsTxId <- publishHydraScriptsAs node Faucet | |
| -- Publish hydra scripts in L1 | |
| hydraScriptsTxId <- publishHydraScriptsAs node Faucet |
| -- This allows to open heads in other heads leveraging the isomorphic nature of | ||
| -- the Hydra Head protocol. | ||
| -- | ||
| -- Basd on a websocket client to the API of one of the underlying head's nodes. |
There was a problem hiding this comment.
Suggested change
| -- Basd on a websocket client to the API of one of the underlying head's nodes. | |
| -- Based on a websocket client to the API of one of the underlying head's nodes. |
|
Can confirm I can follow the instructions and get it working on the branch! Nice :) Note: There are some compile-time errors on the hydra-node tests; but not too important as we aren't merging it; but just FYI if anyone is looking back. |
noonio
reviewed
Sep 16, 2024
| ```shell | ||
| nix run .#hydra-tui -- -c 0.0.0.0:4003 -k inception-demo/wallet.sk | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Note: You need to initialise the head here; i.e. press i in the TUI; then continue on with the rest of the steps.
noonio
approved these changes
Sep 16, 2024
The inception hydra client must only callback with a transaction observed when it is confirmed. Otherwise, subsequent queries of confirmed UTxO will not include the just observed transactions outputs. Changing SnapshotConfirmed to include full txs allows to write the inception hydra client simply without requiring book-keeping of transactions seen. Obviously this breaks many other things.
This is a bit weird in case of --offline as that would not require publishing scripts in the first place. In fact, this is another hint that we might have different chain components, but the cardano backends share more things than the offline one for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not meant to be merged as-is as it contains A LOT of hacks to make this work.
hydra-node --inception.cabal test hydra-cluster --test-options "-m inception"ServerOutputto contain full transactions (easier to handle)hydra-node publish-scriptsuse the same inception command line options (hacky)See issue #1590 for more details on learnings and a how-to.