feat(core): Cleaner way to provide group name to UI

src/core/__fixtures__/agent/ipexCommunicationFixtures.ts

@@ -516,7 +516,7 @@ const multisigParticipantsProps = {
       groupId: "group-id",
       groupInitiator: true,
       groupCreated: true,
-      userName: "IdentifierName2",
+      proposedUsername: "IdentifierName2",
     },
   },
   multisigMembers: {

src/core/__fixtures__/agent/multiSigFixtures.ts

@@ -17,7 +17,7 @@ const memberMetadataRecordProps: IdentifierMetadataRecordProps = {
     groupId: "groupid",
     groupInitiator: true,
     groupCreated: false,
-    userName: "testUser",
+    proposedUsername: "testUser",
   },
 };
 
@@ -119,7 +119,7 @@ const memberIdentifierRecord = {
     groupId: "08f22dee-8cb0-4d65-8600-a82bbc3f6fd7",
     groupInitiator: true,
     groupCreated: true,
-    userName: "testUser",
+    proposedUsername: "testUser",
   },
   updatedAt: new Date("2024-06-28T03:55:04.260Z"),
 } as IdentifierMetadataRecordProps;

src/core/agent/agent.types.ts

@@ -234,7 +234,7 @@ type OobiScan =
   | {
       type: OobiType.MULTI_SIG_INITIATOR;
       groupId: string;
-      connection: ConnectionShortDetails;
+      connection: MultisigConnectionDetails;
     };
 
 interface AgentServicesProps {

src/core/agent/records/identifierMetadataRecord.ts

@@ -5,7 +5,7 @@ interface GroupMetadata {
   groupId: string;
   groupInitiator: boolean;
   groupCreated: boolean;
-  userName: string;
+  proposedUsername: string;
 }
 
 interface IdentifierMetadataRecordProps {
@@ -17,6 +17,7 @@ interface IdentifierMetadataRecordProps {
   theme: number;
   groupMemberPre?: string;
   groupMetadata?: GroupMetadata;
+  groupUsername?: string;
   pendingDeletion?: boolean;
   sxlt?: string;
   tags?: Tags;
@@ -30,6 +31,7 @@ class IdentifierMetadataRecord extends BaseRecord {
   pendingDeletion!: boolean;
   groupMemberPre?: string;
   groupMetadata?: GroupMetadata;
+  groupUsername?: string;
   sxlt?: string;
 
   static readonly type = "IdentifierMetadataRecord";
@@ -47,6 +49,7 @@ class IdentifierMetadataRecord extends BaseRecord {
       this.isDeleted = props.isDeleted ?? false;
       this.groupMetadata = props.groupMetadata;
       this.groupMemberPre = props.groupMemberPre;
+      this.groupUsername = props.groupUsername;
       this.pendingDeletion = props.pendingDeletion ?? false;
       this.sxlt = props.sxlt;
       this._tags = props.tags ?? {};

src/core/agent/records/identifierStorage.test.ts

@@ -91,6 +91,24 @@ describe("Identifier storage test", () => {
     expect(storageService.update).toBeCalled();
   });
 
+  test("Should update identifier groupUsername", async () => {
+    const identifierWithGroupUsername = new IdentifierMetadataRecord({
+      ...identifierMetadataRecordProps,
+      groupUsername: "oldUsername",
+    });
+    storageService.findById.mockResolvedValue(identifierWithGroupUsername);
+
+    await identifierStorage.updateIdentifierMetadata(
+      identifierMetadataRecord.id,
+      {
+        groupUsername: "newUsername",
+      }
+    );
+
+    expect(identifierWithGroupUsername.groupUsername).toBe("newUsername");
+    expect(storageService.update).toBeCalledWith(identifierWithGroupUsername);
+  });
+
   test("Should get all identifier pending deletion", async () => {
     storageService.findAllByQuery.mockResolvedValue([
       {

src/core/agent/records/identifierStorage.ts

@@ -70,6 +70,7 @@ class IdentifierStorage {
         | "creationStatus"
         | "isDeleted"
         | "groupMetadata"
+        | "groupUsername"
         | "pendingDeletion"
       >
     >
@@ -85,6 +86,8 @@ class IdentifierStorage {
       identifierMetadataRecord.isDeleted = metadata.isDeleted;
     if (metadata.groupMetadata !== undefined)
       identifierMetadataRecord.groupMetadata = metadata.groupMetadata;
+    if (metadata.groupUsername !== undefined)
+      identifierMetadataRecord.groupUsername = metadata.groupUsername;
     if (metadata.pendingDeletion !== undefined)
       identifierMetadataRecord.pendingDeletion = metadata.pendingDeletion;
     await this.storageService.update(identifierMetadataRecord);

src/core/agent/services/connectionService.ts

@@ -164,24 +164,23 @@ class ConnectionService extends AgentService {
       sharedIdentifier,
     };
 
-    const connection: ConnectionShortDetails = {
-      id: connectionId,
-      createdAtUTC: connectionDate,
-      oobi: url,
-      status: ConnectionStatus.PENDING,
-      label: alias,
-      contactId: connectionId,
-      ...(groupId ? { groupId } : { identifier: sharedIdentifier ?? "" }),
-    };
-
     if (multiSigInvite) {
       const oobiResult = (await this.resolveOobi(url)) as {
         op: Operation & { response: State };
         connection: Contact;
         alias: string;
       };
-      connection.id = oobiResult.op.response.i;
-      connection.status = ConnectionStatus.CONFIRMED;
+
+      const multisigConnection: MultisigConnectionDetails = {
+        id: oobiResult.op.response.i,
+        createdAtUTC: new Date(oobiResult.op.response.dt).toISOString(),
+        oobi: url,
+        status: ConnectionStatus.CONFIRMED,
+        label: alias,
+        contactId: oobiResult.op.response.i,
+        groupId,
+      };
+
       connectionMetadata.creationStatus = CreationStatus.COMPLETE;
       connectionMetadata.createdAtUTC = oobiResult.op.response.dt;
       connectionMetadata.status = ConnectionStatus.CONFIRMED;
@@ -209,11 +208,21 @@ class ConnectionService extends AgentService {
         return {
           type: OobiType.MULTI_SIG_INITIATOR,
           groupId,
-          connection,
+          connection: multisigConnection,
         };
       }
     }
 
+    const connection: ConnectionShortDetails = {
+      id: connectionId,
+      createdAtUTC: connectionDate,
+      oobi: url,
+      status: ConnectionStatus.PENDING,
+      label: alias,
+      contactId: connectionId,
+      ...(groupId ? { groupId } : { identifier: sharedIdentifier ?? "" }),
+    };
+
     await this.createConnectionMetadata(connectionId, connectionMetadata);
 
     if (!multiSigInvite) {

src/core/agent/services/identifier.types.ts

@@ -10,7 +10,7 @@ interface GroupMetadata {
   groupId: string;
   groupInitiator: boolean;
   groupCreated: boolean;
-  userName: string;
+  proposedUsername: string;
   initiatorName?: string;
 }
 
@@ -28,6 +28,7 @@ interface IdentifierShortDetails {
   creationStatus: CreationStatus;
   groupMetadata?: GroupMetadata;
   groupMemberPre?: string;
+  groupUsername?: string;
 }
 
 interface IdentifierDetails extends IdentifierShortDetails {