fix: onboarding create password invalidate and ssi agent #1308
Conversation
jacklesotatek
requested review from
iFergal,
jorgenavben,
rcmorano and
sdisalvo-crd
as code owners
| tags: | ||
| - '[0-9]+.[0-9]+.[0-9]+*' | ||
| pull_request_target: | ||
| pull_request: |
There was a problem hiding this comment.
this workflow file is actually deprecated, replaced by the new filename build-and-publish-docker-artifacts.yaml
There was a problem hiding this comment.
Good point, thanks! Jack, if you merge develop into this branch - just make sure there are no changes to these files in the final diff and we should be good to go.
I believe this change came for security reasons originally or something.
| -keep class com.aheaditec.freerasp.** { *; } | ||
| -dontwarn com.aheaditec.freerasp.** | ||
| -keep class java.lang.invoke.StringConcatFactory { *; } | ||
| -dontwarn java.lang.invoke.StringConcatFactory |
There was a problem hiding this comment.
develop now has v2.2.2 of freerasp which should have resolved this issue. So these lines can be removed
| # ProGuard rules for capacitor-freerasp | ||
| -keep class com.aheaditec.freerasp.** { *; } | ||
| -dontwarn com.aheaditec.freerasp.** | ||
| -keep class java.lang.invoke.StringConcatFactory { *; } |
There was a problem hiding this comment.
This file no longer exists on develop
| Then(/^user can see Welcome modal$/, async function() { | ||
| await WelcomeModal.loads(); | ||
|
|
||
| const profileTypeTitle = $("p.title"); |
There was a problem hiding this comment.
OK, this PR seems to be the same as #1301
Lets close on and fix all comments on both PRs in one. :)
Description
Please include a summary of the changes and a brief description about this PR.
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Design Review