QA review of #8 #87
Merged
QA review of #8 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
approved these changes
Mar 19, 2019
| ] | ||
| (ProcessHasExited name code) <- launch commands | ||
| name `shouldBe` cmdName (commands !! 0) | ||
| name `shouldBe` cmdName (commands !! 1) |
There was a problem hiding this comment.
Yeah, just wanted to test different orders of commands added to the launcher... added few more test, because this alone didn't make any sense indeed :)
piotr-iohk
force-pushed
the
piotr/8/qa-review
branch
from
1f11e78 to
4904d2f
Compare
piotr-iohk
force-pushed
the
piotr/8/qa-review
branch
from
82a731a to
214157b
Compare
jamescheuk91
pushed a commit
to jamescheuk91/cardano-sl
that referenced
this pull request
Mar 28, 2019
3930: [87] Copy `NodeStateAdaptor` from the wallet to the node r=KtorZ a=Anviking ## Description We don't want to use NodeStateAdaptor from the wallet. We'd like to decouple the wallet from the node, and talk over an API (the Node API). To aid the transition, I have abruptly copied the wallet `NodeStateAdaptor` to the Node, so that it can serve the following additional protocol parameters in the node-settings endpoint: - slotId - slotCount - maxTxSize - feePolicy - securityParameter ## Linked issue cardano-foundation/cardano-wallet#87 Co-authored-by: Johannes Lund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Overview
POSIXSpec.mdand added additional infoLauncherSpec.hs(just changed the order of commands in 1 test)Comments