Address Discovery (Sequential) #51
Conversation
| AddressPoolGap (toEnum g) | ||
|
|
||
| -- | Smart constructor for 'AddressPoolGap' | ||
| mkAddressPoolGap :: Word8 -> Either MkAddressPoolGapError AddressPoolGap |
There was a problem hiding this comment.
don't we want :
mkAddressPoolGap
:: Word8
-> Either MkAddressPoolGapError AddressPoolGap
?
There was a problem hiding this comment.
Not necessarily. The line is still within 80 chars, so we don't necessarily have to wrap it.
| -- In practice, we always have: | ||
| -- | ||
| -- > mkAddressPool key g cc (addresses pool) == pool | ||
| addresses :: AddressPool -> [Address] |
There was a problem hiding this comment.
the same comment as above
| | otherwise = pool | ||
| where | ||
| edge = Map.size (indexedAddresses pool) | ||
| isOnEdge = edge - fromEnum ix <= fromEnum (gap pool) |
There was a problem hiding this comment.
the definition of isOnEdge follows from the standard?
There was a problem hiding this comment.
Well, the specification is rather evasive about how this should be handled.
- scan addresses of the external chain; respect the gap limit described below
- if no transactions are found on the external chain, stop discovery
The approach above is how we've translated this, and works fairly well (cf property tests)
| newAddress = keyToAddress . deriveAddressPublicKey key cc | ||
|
|
||
| -- | Fails hard if an invariant does not hold, or proceed. | ||
| invariant |
There was a problem hiding this comment.
maybe it is good idea to extract invariant function in helper file or use the one already defined in src/Cardano/Wallet.hs :
173:invariant
174- :: String -- ^ A title / message to throw in case of violation
175- -> a
176- -> (a -> Bool)
177- -> a
178:invariant msg a predicate
There was a problem hiding this comment.
Whoops. My bad. I intended to use the one from src/Cardano/Wallet.hs indeed, though I hadn't rebase yet at this moment and just copy/pasted it quickly. Will remove 👍
KtorZ
force-pushed
the
KtorZ/#21/ed25519-address-derivation
branch
from
35cb00e to
63e9070
Compare
KtorZ
force-pushed
the
KtorZ/#22/port-address-discovery
branch
from
e89cd11 to
1a5805c
Compare
KtorZ
force-pushed
the
KtorZ/#22/port-address-discovery
branch
from
1a5805c to
d0b1c37
Compare
Issue Number
#22
Overview
cardano-wallet-legacyAddressPoolmodule according to the findings in the prototype, also making it a plain data-structure rather than accepting a function in its internal representationComments