Integration tests covering ErrInputsDepleted case #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
approved these changes
Jul 3, 2019
|
|
||
| let addr1 = encodeAddress (Proxy @t) (getApiT $ fst $ head addrs ^. #id) | ||
| let addr2 = encodeAddress (Proxy @t) (getApiT $ fst $ addrs !! 1 ^. #id) | ||
| let addr3 = encodeAddress (Proxy @t) (getApiT $ fst $ addrs !! 2 ^. #id) |
There was a problem hiding this comment.
I am neat-picking, but, could have been:
let addr1 = encodeAddress (Proxy @t) (getApiT $ fst $ addrs !! 1 ^. #id)
let addr2 = encodeAddress (Proxy @t) (getApiT $ fst $ addrs !! 2 ^. #id)
let addr3 = encodeAddress (Proxy @t) (getApiT $ fst $ addrs !! 3 ^. #id)😬
paweljakubas
approved these changes
Jul 3, 2019
piotr-iohk
force-pushed
the
piotr/random_testing
branch
from
8515d6b to
721386b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Overview
Comments