Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlite: Use the structured logging approach #492

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Sqlite: Use the structured logging approach #492

merged 1 commit into from
Jul 1, 2019

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Jul 1, 2019

Relates to issue #354.

Overview

  • Uses a data type for log messages, then converts them to text at the Sqlite module boundary.

Comments

  • We should consider making this the standard logging style for cardano-wallet.

@rvl rvl added this to the Logging milestone Jul 1, 2019
@rvl rvl self-assigned this Jul 1, 2019
@piotr-iohk piotr-iohk mentioned this pull request Jul 1, 2019
Closed
13 tasks
paweljakubas
paweljakubas approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I will rebase the branch and merge it

@paweljakubas paweljakubas force-pushed the rvl/354/structured-logging branch from ebfaaee to b909cd4 Compare July 1, 2019 10:51
@paweljakubas paweljakubas merged commit 50ce6c7 into master Jul 1, 2019
@paweljakubas paweljakubas deleted the rvl/354/structured-logging branch July 1, 2019 11:13
@rvl rvl mentioned this pull request Jul 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@rvl rvl

Labels
None yet
Projects
None yet
Milestone
Logging
Development

Successfully merging this pull request may close these issues.
2 participants
@rvl @paweljakubas