Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test invalid cli args and params #489

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Test invalid cli args and params #489

merged 1 commit into from
Jul 1, 2019

Conversation

piotr-iohk
Copy link
Contributor

Issue Number

#460

Overview

  • I have added more tests for checking invalid params and args on CLI

Comments

-- transaction create
, "transaction create " ++ wid ++ " --payment"
, "transaction create " ++ wid ++ " --payment 22@2cWKMJemoBaiPcjZZKQzTHzjRkaAee5dx246Ren8U5KcDGt9QX6FZQPskzykhYL1AW62U --payment"
, "transaction create --port " ++ wid ++ " --payment 22@ --payment"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting to reach this when trying out different variations on --payment parameter but was never able to...

(perhaps this is never reached?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be caught earlier by the parser itself (docopt) and never makes it to our code.

@piotr-iohk piotr-iohk self-assigned this Jun 28, 2019
@piotr-iohk piotr-iohk requested a review from KtorZ June 28, 2019 12:55
@KtorZ KtorZ mentioned this pull request Jun 28, 2019
10 tasks
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, will come in handy with the optparse-applicative refactoring.

@KtorZ KtorZ merged commit e60d135 into master Jul 1, 2019
@KtorZ KtorZ deleted the piotr/cli_testing branch July 1, 2019 08:36
@KtorZ KtorZ modified the milestone: Bugs Sprint 25-26 Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants