re-start restoration workers when restarting the application #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
commented
Jun 26, 2019
| @@ -753,7 +753,7 @@ locateErrors residue len | |||
| let p1 = (l_s1 - l_s0 + 1023) `mod` 1023 in | |||
| if (p1 >= len) then [] else | |||
| let l_e1 = l_s0 + (1023 - 997) * p1 in | |||
| if (l_e1 `mod` 33 > 0) then [] else [p1] | |||
| [p1 | l_e1 `mod` 33 <= 0] | |||
There was a problem hiding this comment.
a bit unrelated but it seems that hlint had an update in our CI :|
|
Perhaps any test would be handy? |
|
ah, ok - just read the comment in description...
|
Maybe just looking at the logs after restarting the server? (similarly to logging tests in #474 ) |
KtorZ
force-pushed
the
KtorZ/fix-restoration-workers
branch
from
deab077 to
808f520
Compare
piotr-iohk
reviewed
Jun 27, 2019
| @@ -711,6 +714,22 @@ tearDown ctx = do | |||
| Left e -> error $ "deleteAllWallets: Cannot return wallets: " <> show e | |||
| Right s -> s | |||
|
|
|||
| -- | Wait a booting wallet server to has started. Wait up to 30s or fail. | |||
There was a problem hiding this comment.
Wait a booting wallet server to has started (or to has started)
There was a problem hiding this comment.
Aaaah. Damn. I clicked merge too fast 🤦♂️
I'll fix in another PR.
piotr-iohk
approved these changes
Jun 27, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#484
Overview
Comments
I have not yet find a nice & easy way to test this 🤔 ...