Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review logging in API layer #485

Merged
merged 4 commits into from
Jun 27, 2019
Merged

Review logging in API layer #485

merged 4 commits into from
Jun 27, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Jun 26, 2019

Issue Number

#354

Overview

  • I have reviewed application-level logging, adding some, removing some, changing some.

Comments

@KtorZ KtorZ self-assigned this Jun 26, 2019
@KtorZ KtorZ requested review from Anviking, akegalj and piotr-iohk and removed request for Anviking June 26, 2019 13:19
akegalj
akegalj approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@akegalj akegalj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KtorZ KtorZ force-pushed the KtorZ/logging-api-layer branch from b2031e4 to d3cfc6c Compare June 27, 2019 08:25
@KtorZ KtorZ merged commit 59a65e7 into master Jun 27, 2019
@KtorZ KtorZ deleted the KtorZ/logging-api-layer branch June 27, 2019 09:29
@KtorZ KtorZ mentioned this pull request Jul 1, 2019
Closed
13 tasks
@KtorZ KtorZ added this to the Logging milestone Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akegalj akegalj akegalj approved these changes

@Anviking Anviking Awaiting requested review from Anviking

@piotr-iohk piotr-iohk Awaiting requested review from piotr-iohk

Assignees

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
Logging
Development

Successfully merging this pull request may close these issues.
2 participants
@KtorZ @akegalj