Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide ToText and FromText instances for Hash "Genesis" #482

Merged
merged 4 commits into from
Jun 26, 2019
Merged

Provide ToText and FromText instances for Hash "Genesis" #482

merged 4 commits into from
Jun 26, 2019

Conversation

jonathanknowles
Copy link
Contributor

Issue Number

#357

This PR enables us to parse user-provided genesis hash values from the CLI.

Overview

This PR:

  • provides ToText and FromText instances for the Hash "Genesis" type.
  • removes duplication among ToText and FromText instances for the family of Hash t types.

Comments

@jonathanknowles jonathanknowles self-assigned this Jun 26, 2019
KtorZ
KtorZ reviewed Jun 26, 2019
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have corresponding roundtrips for this, a bit of negative tests too.

@jonathanknowles
Copy link
Contributor Author

Would be good to have corresponding roundtrips for this, a bit of negative tests too.

Added!

KtorZ
KtorZ approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanknowles jonathanknowles merged commit 28d1724 into master Jun 26, 2019
@jonathanknowles jonathanknowles deleted the jonathanknowles/hash-genesis-to-from-text branch June 26, 2019 09:28
@KtorZ KtorZ mentioned this pull request Jul 3, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

Assignees

@jonathanknowles jonathanknowles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanknowles @KtorZ