Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on integration tests for Jörmungandr (Part I: Addresses & Wallets scenarios) #470

Merged
merged 7 commits into from
Jun 25, 2019

Conversation

paweljakubas
Copy link
Contributor

@paweljakubas paweljakubas commented Jun 25, 2019

Issue Number

#358

Overview

  • I have turn on wallet/addresses scenario integration tests
  • I have added Buildable instance for Tx in shared
  • I have added feePolicy arg to newWalletLayer and enabled correct fee calculation for cardanoPolicy and jormungandrPolicy

Comments

@paweljakubas paweljakubas requested review from Anviking and KtorZ June 25, 2019 09:58
@paweljakubas paweljakubas self-assigned this Jun 25, 2019
@KtorZ KtorZ mentioned this pull request Jun 25, 2019
3 tasks
@Anviking Anviking force-pushed the paweljakubas/358/turn-on-integration-tests branch from df81b5c to fc5d9ed Compare June 25, 2019 11:33
@Anviking
Copy link
Member

I did this git rebase -i and pushed

pick 3317355a turn on addresses and wallets scenarios
pick 806b8dfe Add support for posting txs in JormungandrLayer and NetworkLayer
drop f66e6c23 logs
pick a1f24cf7 enable logging in integration tests + delay between calls in expectEventually
pick a2ba77f7 Improve on generation with retrieve and new generate option, also printing public key
drop 7463e20a Fix: mkStdTx should sign with the /current/ txId
pick 14bd8dec add buildable instance for tx
pick 359c42b1 add feePolicy arg to newWalletLayer
drop 556a24a8 remove unneeded traces

pick df81b5c7 hlint and nix
# would preferably squash hlint part but can't find where it should be 🤷‍♂ 

@paweljakubas paweljakubas force-pushed the paweljakubas/358/turn-on-integration-tests branch from fc5d9ed to a5023f7 Compare June 25, 2019 11:53
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -82,6 +83,10 @@ data TxSizeLinear =
cardanoPolicy :: TxSizeLinear
cardanoPolicy = TxSizeLinear (Quantity 155381) (Quantity 43.946)

-- | Hard-coded zero fee policy for Jormungandr
jormungandrPolicy :: TxSizeLinear
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I am a tiny bit worried that our test setup will differ from exe setup eventually, but that's not just about the fee policy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, ideally, this should come from the genesis block for Jörmungandr. I'll make a PR A.S.A.P

@KtorZ KtorZ changed the title turn on integration tests Turn on integration tests for Jörmungandr (Part I: Addresses & Wallets scenarios) Jun 25, 2019
@KtorZ KtorZ merged commit 405ca4e into master Jun 25, 2019
@KtorZ KtorZ deleted the paweljakubas/358/turn-on-integration-tests branch June 25, 2019 12:19
@KtorZ KtorZ added this to the Jörmungandr Integration Testing milestone Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants