another attempt trying to cope with 500 when fetching network tip shortly after init (bridge) #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
force-pushed
the
KtorZ/network-tip-500
branch
2 times, most recently
from
baca6b5 to
ecf3bf7
Compare
…rtly after init (bridge)
KtorZ
force-pushed
the
KtorZ/network-tip-500
branch
from
ecf3bf7 to
f56668d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
N/A
Overview
I have added an error message to the bridge when failing to fetch the tip from storage for an unknown reason. This allows for "grepping" on that message in our network layer and handle the failure correctly (see https://github.com/KtorZ/cardano-http-bridge/commit/224b5f40a764cce136f00370b634c2b33a8b43930
Modified nix machinery (hopefully) to use this newer version of the bridge in the nightly tests
Move the
waitForConnectionto be earlier in the code since we actually start sending requests to the bridge before entering the benchmark loop!Comments
Will try to trigger a nightly build from this branch to see ...
edit: Nightly tests have passed successfully 🎉 (https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/110)