Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review BlockSyncer Tests: Separate IO from pure code. #44

Merged
merged 41 commits into from
Mar 11, 2019
Merged

Review BlockSyncer Tests: Separate IO from pure code. #44

merged 41 commits into from
Mar 11, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Mar 11, 2019

Issue Number

Overview

  • I have ...

Comments

KtorZ added 30 commits March 11, 2019 09:41
@KtorZ
refactoring #1 | inline intermediate functions to see more clearly + …
1163aeb 
…remove debug console prints
@KtorZ
refactoring #2 | review indentation of 'where' clause
66db21a
@KtorZ
refactoring #3 | inline loop and remove test intrumentation from test…
1b28cb1 
… logic
@KtorZ
refactoring #4 | define generator for ticking args in a declarative m…
05864aa 
…anner
@KtorZ
refactoring #5 | purify tickingFunctionTest and make it a monadic pro…
e7d5d9d 
…perty
@KtorZ
refactoring #6 | review naming in Arbitrary TickingArgs
6bd381b
@KtorZ
refactoring #7 | use guards in mkConsecutiveTestBlocks
842775d
@KtorZ
refactoring #8 | define single block generator from previous block
2ac72be
@KtorZ
refactoring #9 | use 'fromPreviousBlock' and start loop with an alrea…
5696832 
…dy initialize list
@KtorZ
refactoring #10 | purify mkConsecutiveTestBlocks by defining a test h…
85e7dea 
…ash function
@KtorZ
refactoring #11 | switch argument positions in mkConsecutiveTestBlocks
155bbb7
@KtorZ
refactoring #12 | replace loop with built-in list 'iterate'
95928b3
@KtorZ
refactoring #13 | define Arbitrary instance for creating consecutive …
c02f1c9 
…blocks
@KtorZ
refactoring #14 | replace mkConsecutiveBlocks with a property parameter
e673958
@KtorZ
refactoring #15 | use 'newMVar' instead or 'newEmptyMVar' + 'putMVar'
c4bf97d
@KtorZ
refactoring #16 | remove unecessary IO in 'writeToIORefAction'
05af556
@KtorZ
refactoring #17 | replace takeMVar + putMVar with modifyMVar
0ef7b8c
@KtorZ
refactoring #18 | review naming for 'writeToIORefAction' --> 'reader'
48f8fda
@KtorZ
refactoring #19 | use a 'Map.lookup' instead of 'List.filter' + patte…
46bcf6c 
…rn-match
@KtorZ
refactoring #20 | remove 'BlocksConsumed' wrapper
9ddfebb
@KtorZ
refactoring #21 | generalize reader with polymorphic parametrism
e64d635
@KtorZ
refactoring #22 | review pushNextBlocks indentation
8adc703
@KtorZ
refactoring #23 | group case pattern matches using tuple
28501a9
@KtorZ
refactoring #24 | remove 'Hash BlockHeader' from the block to inject
bf5d193
@KtorZ
refactoring #25 | use synchronization lock instead of computed times
033898f
@KtorZ
refactoring #26 | Move generation of duplicated blocks onto 'Arbitrar…
b40750f 
…y Blocks'
@KtorZ
refactoring #27 | remove 'chunkSizes' in a favor of inline random sel…
6309e1c 
…ection
@KtorZ
refactoring #28 | remove 'DeliveryMode' in favor of the most general …
a53bc0b 
…case
@KtorZ
refactoring #29 | cleanup wrapper types
43e0c9b
@KtorZ
refactoring #30 | generalize pushNextBlocks with parametric polymorphism
065c050
KtorZ added 11 commits March 11, 2019 09:43
@KtorZ
refactoring #31 | rename pushNextBlocks to 'writer'
1b97e4d
@KtorZ
refactoring #32 | define reader on Block instead of BlockHeaderHash
633d8ab
@KtorZ
refactoring #33 | replace old reader with reader'
ff6c5c0
@KtorZ
refactoring #34 | move creation of writer MVar inside writer action
d3b76df
@KtorZ
refactoring #35 | remove header hash from 'Blocks'
da229b9
@KtorZ
refactoring #36 | rename 'consecutiveBlocks' into 'blocks'
0e68efd
@KtorZ
refactoring #37 | re-organize module to separate effectful logic from…
b292211 
… declarations
@KtorZ
refactoring #38 | move waiting logic into dedicated function
a9a0c8c
@KtorZ
refactoring #39 | move 'done' and 'readerChan' initialization into re…
ab904ec 
…ader and writer
@KtorZ
refactoring #40 | use Millisecond instead of Second for shorter tests
66f24a6
@KtorZ
refactoring #41 | Move creation of blocks from writer to 'Arbitrary B…
858c9ac 
…locks'
@KtorZ KtorZ changed the title Paweljakubas/3/ticking function review Review BlockSyncer Tests: Separate IO from pure code. Mar 11, 2019
@KtorZ KtorZ merged commit 600f3cf into paweljakubas/3/ticking-function Mar 11, 2019
@KtorZ KtorZ deleted the paweljakubas/3/ticking-function-review branch March 11, 2019 10:05
@KtorZ
Copy link
Member Author

KtorZ commented Mar 11, 2019

Whoops. I think I didn't squash the commits after all 😅 ...
@paweljakubas I'll leave that to you when you rebase the branch.

@KtorZ KtorZ self-assigned this Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KtorZ