Handle getBlockHeader special cases for proofs
#394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
force-pushed
the
anviking/386/handle-header-proofs
branch
3 times, most recently
from
9536786 to
0b40ed5
Compare
Anviking
force-pushed
the
anviking/386/handle-header-proofs
branch
from
0b40ed5 to
50bf389
Compare
1 task
Anviking
force-pushed
the
anviking/386/handle-header-proofs
branch
from
50bf389 to
7af29d8
Compare
Anviking
force-pushed
the
anviking/386/handle-header-proofs
branch
from
7af29d8 to
38a02d9
Compare
akegalj
reviewed
Jun 11, 2019
|
|
||
| -- We could make sure we get the right kind of proof, but we don't need to. | ||
| -- Just checking that the length is not totally wrong, is much simpler | ||
| -- and gives us sanity about the binary format being correct. |
There was a problem hiding this comment.
I also think this is good enough
KtorZ
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#386
Overview
getBlockHeaderwhen it contains a proof. (see added comment ingetBlockHeader)Comments
TestVectortype might be a good idea soon. But I didn't do it yet.