-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change wallet currentTip
from SlotId
to BlockHeader
#384
Conversation
|
currentTip
from SlotId
to BlockHeader
1890f2a
to
59c7c69
Compare
59c7c69
to
a746e77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
715763c
to
29a490a
Compare
rebased on top of master + improved comment for |
df46b6e
to
dfa4464
Compare
Squashed relevant commits into |
@Anviking Not so sure about the squash here. I think some commits deserved to be separated for readability. Styling stuff and indentation fixes, sure; but structural changes were better off separated IMO. |
988ddc1
to
19f89fe
Compare
step 1 step 2: core compiling step 3: add genesis parent header hash Step 4: ? and fix tests fix wrong copied/pasted comments and tags
19f89fe
to
e46b2fa
Compare
Issue Number
#219
Overview
SlotId
toBlockHeader
Comments
BlockHeader
in the futureEither tip1 tip2
as(Maybe tip1, Maybe tip2)
, we introduce a new dimension of complexity in the database, which might be undesired)