Clean ups of Sqlite test code #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good to me.
Just a small point w.r.t. to Haddock comments. If you write the name of a type in a Haddock comment, then putting it in single quotes will get Haddock to create a hyperlink that goes to type.
For example:
-- | A mock representation of the 'Wibble' data type.(If Haddock can find a definition of Wibble, then the generated Haddock documentation will link it up.)
KtorZ
force-pushed
the
rvl/154/sqlite-cleanup
branch
from
ac60b36 to
41e89a5
Compare
KtorZ
force-pushed
the
rvl/154/sqlite-cleanup
branch
from
41e89a5 to
6bb8d50
Compare
KtorZ
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #154
Base branch is PR #373
Overview