-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sqlite: Initial benchmark for putTxHistory #341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
force-pushed
the
rvl/154/db-bench
branch
3 times, most recently
from
June 2, 2019 23:42
86ed114
to
1520539
Compare
1 task
This lays out benchmarks in a table, with comments describing the parameters in that column. Using a record type doesn't enhance readability at all.
The function repsertMany does what I thought putMany did. When there is a conflict it updates the rows. This means that we don't need to delete before inserting.
It would have exploded if there were more than 999 TxMeta or PendingTx. I tried Esqueleto and it can't do this query. Actually, it could express the query, but the generated SQL was invalid. And the code looked just as bad as raw SQL.
KtorZ
approved these changes
Jun 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few top-level comments + some extra dbChunked
on insertMany
. Merging as it is so we can better iterate on it.
cc @rvl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #154.
Overview
Comments
putTxHistory
performance sucks when running it in batches of 10 (no surprise).removeWallet
code ... our old friend(?,?,...,?): too many SQL variables
.