Strengthen the precondition for the Bech32 mixed-case mutation test. #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to be best to put a big lock around all operations which use
the SQLite connection.
I was getting the following failed test:
λ> quickCheck (prop_parallel db)
*** Failed! Exception: 'SQLite3 returned ErrorError while attempting to perform step: not an error' (after 5 tests and 3 shrinks):
ParallelCommands
{ prefix = Commands { unCommands = [] }
, suffixes =
[ Pair
{ proj1 =
Commands
{ unCommands =
[ Command
(At (ReadTxHistory (Val (MWid "c"))))
(At (Resp (Right (TxHistory (fromList [])))))
[]
]
}
, proj2 =
Commands
{ unCommands =
[ Command
(At (PutTxHistory (Val (MWid "a")) (fromList [])))
(At (Resp (Left (NoSuchWallet (Reference (Symbolic (Var 0)))))))
[ Var 0 ]
]
}
}
]
}
1 task
Sqlite: add more locking to DBLayer methods
It's possible to change the case of a given character of a Bech32 string and yet not produce a mixed-case string. In such cases, we can't expect that the `decode` function will fail with a `StringToDecodeHasMixedCase` error. To prevent the test failing, we change the precondition to actually check that the string is in mixed case.
jonathanknowles
force-pushed
the
jonathanknowles/bech32-fix-mixed-case-test
branch
from
ce19693 to
15fbefb
Compare
KtorZ
changed the base branch from
master
to
jonathanknowles/bech32-fix-index-limits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#339
Overview
It's possible to change the case of a given character of a Bech32 string and yet not produce a mixed-case string.
In such cases, we can't expect that the
decodefunction will fail with aStringToDecodeHasMixedCaseerror.Comments