Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more examples from https://git.io/fjBIN in tests #319

Merged
merged 1 commit into from
May 24, 2019

Conversation

piotr-iohk
Copy link
Contributor

Include more examples from https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki#test-vectors in tests

Issue Number

Overview

  • I did just that

Comments

@piotr-iohk piotr-iohk requested a review from KtorZ May 24, 2019 12:49
@piotr-iohk piotr-iohk self-assigned this May 24, 2019
, "BC1QR508D6QEJXTDG4Y5R3ZARVARYV98GJ9P"
, "bc1zw508d6qejxtdg4y5r3zarvaryvqyzf3du"
, "tb1qrp33g0q5c5txsp9arysrx4k6zdkfs4nce4xj0gdcccefvpysxf3pjxtptv"
, "bc1gmk9yu"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid segwit addresses but still valid bech32 strings 👍

@KtorZ KtorZ merged commit cf00b3b into master May 24, 2019
@iohk-bors iohk-bors bot deleted the piotr/bech32_update_tests branch May 24, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants