Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Fee Window for Tx scenarios #317

Merged
merged 2 commits into from
May 24, 2019
Merged

Review Fee Window for Tx scenarios #317

merged 2 commits into from
May 24, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented May 24, 2019 •
edited
Loading

Issue Number

#316

Overview

  • I have improved error message of expectFieldBetween
  • I have adjusted fee window for tx scenario. I actually considered the total amount in the past instead of the fee themselves.

Comments

@KtorZ KtorZ requested a review from piotr-iohk May 24, 2019 11:00
@KtorZ KtorZ self-assigned this May 24, 2019
piotr-iohk
piotr-iohk approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KtorZ KtorZ merged commit 589c27b into master May 24, 2019
@iohk-bors iohk-bors bot deleted the KtorZ/316/fee-window-tx-scenarios branch May 24, 2019 11:16
@KtorZ KtorZ mentioned this pull request May 24, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-iohk piotr-iohk piotr-iohk approved these changes

Assignees

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KtorZ @piotr-iohk