Increase timeout for node connection in e2e tests #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…may take more than 1h on node version bumps
piotr-iohk
force-pushed
the
piotr/increase-timeout-for-node-connection-in-e2e-tests
branch
from
0e827f0 to
3f09a7c
Compare
Anviking
approved these changes
Jan 12, 2022
piotr-iohk
deleted the
piotr/increase-timeout-for-node-connection-in-e2e-tests
branch
1 task
iohk-bors bot
added a commit
that referenced
this pull request
Jan 14, 2022
3081: Increase timeouts for fetching node in benchmarks and e2e tests r=piotr-iohk a=piotr-iohk - [x] I have increased timeouts in restoration benchmarks and e2e tests ### Comments Follow up to #3079. - e2e tests 120 mins was not enough for [MacOS](https://github.com/input-output-hk/cardano-wallet/actions/runs/1689464914). - 🧪 [Testing](https://github.com/input-output-hk/cardano-wallet/actions/runs/1691714591). 180mins ✔️ - hopefully the same issue in [benchmarks](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1216#68ecaf3e-2649-4d9e-804e-bef3bad97fc). - 🧪 [Testing](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1218) 180mins ❌ - 🧪 [Testing](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1219) 240mins ✔️ (build failed due to cancellation signal 🤔 , but passed through connecting to the node) ### Issue Number <!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles. Note: Jira issues of the form ADP- will be auto-linked. --> Co-authored-by: Piotr Stachyra <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
Jan 14, 2022
3081: Increase timeouts for fetching node in benchmarks and e2e tests r=piotr-iohk a=piotr-iohk - [x] I have increased timeouts in restoration benchmarks and e2e tests ### Comments Follow up to #3079. - e2e tests 120 mins was not enough for [MacOS](https://github.com/input-output-hk/cardano-wallet/actions/runs/1689464914). - 🧪 [Testing](https://github.com/input-output-hk/cardano-wallet/actions/runs/1691714591). 180mins ✔️ - hopefully the same issue in [benchmarks](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1216#68ecaf3e-2649-4d9e-804e-bef3bad97fc). - 🧪 [Testing](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1218) 180mins ❌ - 🧪 [Testing](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1219) 240mins ✔️ (build failed due to cancellation signal 🤔 , but passed through connecting to the node) ### Issue Number <!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles. Note: Jira issues of the form ADP- will be auto-linked. --> Co-authored-by: Piotr Stachyra <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
Jan 18, 2022
3081: Increase timeouts for fetching node in benchmarks and e2e tests r=rvl a=piotr-iohk - [x] I have increased timeouts in restoration benchmarks and e2e tests ### Comments Follow up to #3079. - e2e tests 120 mins was not enough for [MacOS](https://github.com/input-output-hk/cardano-wallet/actions/runs/1689464914). - 🧪 [Testing](https://github.com/input-output-hk/cardano-wallet/actions/runs/1691714591). 180mins ✔️ - hopefully the same issue in [benchmarks](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1216#68ecaf3e-2649-4d9e-804e-bef3bad97fc). - 🧪 [Testing](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1218) 180mins ❌ - 🧪 [Testing](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1219) 240mins ✔️ (build failed due to cancellation signal 🤔 , but passed through connecting to the node) ### Issue Number <!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles. Note: Jira issues of the form ADP- will be auto-linked. --> Co-authored-by: Piotr Stachyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even 1hmore than 1h on node version bumpsComments
https://github.com/input-output-hk/cardano-wallet/runs/4788838771?check_suite_focus=true
Issue Number