Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regenerate-byron.sh to comply with current cardano-cli #3072

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

piotr-iohk
Copy link
Contributor

  • Fix regenerate-byron.sh to comply with current cardano-cli

Comments

Issue Number

@piotr-iohk piotr-iohk self-assigned this Jan 4, 2022
--delegate-share 1 \
--avvm-entry-count 0 \
--avvm-entry-balance 0 \
--protocol-parameters-file byron.genesis.spec.json \
--genesis-output-dir tmp

yq -y . < tmp/genesis.json > byron-genesis-init.yaml
cat tmp/genesis.json | yq e -P - > byron-genesis-init.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very different yq from the one I have... maybe let's just use json.

Suggested change
cat tmp/genesis.json | yq e -P - > byron-genesis-init.yaml
jq . tmp/genesis.json > byron-genesis-init.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it seems there are two:

I had the latter, going back to the first one... (as it seems it is used here and there across different scripts)

Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@piotr-iohk piotr-iohk merged commit d7cfe75 into master Jan 5, 2022
@piotr-iohk piotr-iohk deleted the piotr/fix-regenerate-byron-sh branch January 5, 2022 14:40
WilliamKingNoel-Bot pushed a commit that referenced this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants