Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cardano-addresses to 3.7.0 #3063

Merged
merged 5 commits into from
Dec 15, 2021
Merged

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Dec 15, 2021

Updates cardano-addresses to 3.7.0, which adds an address_type field to the inspectAddress output.

Issue Number

DDW-742

@rvl rvl requested a review from paweljakubas December 15, 2021 17:05
@rvl rvl self-assigned this Dec 15, 2021
@@ -2085,6 +2085,11 @@ components:
description: Only for 'Byron' style.
type: string
format: base16
address_type:
description: The raw type field of the address.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should not somewhere here also add the table as in cardano-addresses describing codes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added table and some tests.

Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine - we will see if all tests pass. We can maybe add some assertions in integration testing? it should be "address_type":0 as we are dealing mainly with base addressess having in both payment and staking credential key hashes

@piotr-iohk
Copy link
Contributor

bors try

iohk-bors bot added a commit that referenced this pull request Dec 15, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 15, 2021

try

Build succeeded:

@piotr-iohk
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 15, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 760140e into master Dec 15, 2021
@iohk-bors iohk-bors bot deleted the rvl/ddw-742/bump-cardano-addresses branch December 15, 2021 23:12
WilliamKingNoel-Bot pushed a commit that referenced this pull request Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants