-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cardano-addresses to 3.7.0 #3063
Conversation
specifications/api/swagger.yaml
Outdated
@@ -2085,6 +2085,11 @@ components: | |||
description: Only for 'Byron' style. | |||
type: string | |||
format: base16 | |||
address_type: | |||
description: The raw type field of the address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should not somewhere here also add the table as in cardano-addresses describing codes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added table and some tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fine - we will see if all tests pass. We can maybe add some assertions in integration testing? it should be "address_type":0 as we are dealing mainly with base addressess having in both payment and staking credential key hashes
bors try |
tryBuild succeeded: |
bors r+ |
Build succeeded: |
Updates cardano-addresses to 3.7.0, which adds an
address_type
field to the inspectAddress output.Issue Number
DDW-742