Fix broken build from cardano-ledger-specs repo renaming #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Run ``` git grep -l 'hk/cardano-ledger-specs' | xargs sed -i 's/cardano-ledger-specs/cardano-ledger/g' ``` 2. Created a cardano-wallet/deps-for-node-1.30.1 on the new repo to ensure the revision we need exists.
Anviking
commented
Dec 13, 2021
| @@ -14,12 +14,12 @@ | |||
| - Low-Level Specifications | |||
| - [[Byron] On-Chain Binary Formats](https://github.com/input-output-hk/cardano-sl/blob/master/docs/on-the-wire/current-spec.cddl) | |||
| - [[Shelley] Network Binary Formats - Draft](https://github.com/input-output-hk/ouroboros-network/blob/master/ouroboros-network/test/messages.cddl) | |||
| - [[Shelley] On chain Binary formats - Draft](https://github.com/input-output-hk/cardano-ledger-specs/blob/master/shelley/chain-and-ledger/cddl-spec/shelley.cddl#L32) | |||
| - [[Shelley] On chain Binary formats - Draft](https://github.com/input-output-hk/cardano-ledger/blob/master/shelley/chain-and-ledger/cddl-spec/shelley.cddl#L32) | |||
There was a problem hiding this comment.
Seems broken anyway 🤷♂️
Anviking
force-pushed
the
anviking/fix-cardano-ledger
branch
from
c4464ef to
c76d12d
Compare
HeinrichApfelmus
approved these changes
Dec 13, 2021
Anviking
force-pushed
the
anviking/fix-cardano-ledger
branch
from
c76d12d to
b86fd06
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 13, 2021
3055: Fix broken build from cardano-ledger-specs repo renaming r=Anviking a=Anviking - [x] `git grep -l 'hk/cardano-ledger-specs' | xargs sed -i 's/cardano-ledger-specs/cardano-ledger/g'` - [x] Ensure f827a4321e42f528e25f6079f7af3eb18f10d391 still exists in the repo - [x] `./nix/regenerate.sh` - [x] Revert a few links to spec documents in hydra, where cardano-ledger-specs is still used ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number <!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles. Note: Jira issues of the form ADP- will be auto-linked. --> Co-authored-by: Johannes Lund <[email protected]>
|
Build failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 13, 2021
3055: Fix broken build from cardano-ledger-specs repo renaming r=Anviking a=Anviking - [x] `git grep -l 'hk/cardano-ledger-specs' | xargs sed -i 's/cardano-ledger-specs/cardano-ledger/g'` - [x] Ensure f827a4321e42f528e25f6079f7af3eb18f10d391 still exists in the repo - [x] `./nix/regenerate.sh` - [x] Revert a few links to spec documents in hydra, where cardano-ledger-specs is still used ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number <!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles. Note: Jira issues of the form ADP- will be auto-linked. --> Co-authored-by: Johannes Lund <[email protected]>
|
Timed out. |
|
Gah… bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git grep -l 'hk/cardano-ledger-specs' | xargs sed -i 's/cardano-ledger-specs/cardano-ledger/g'./nix/regenerate.shComments
Issue Number
#3054