Retry connection to node on MuxSDU*Timeout error #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These errors are thrown when the bandwidth of the node-to-client inter-process communication (IPC) has deteriorated and didn't yield data for 30 seconds. Chances are that the system is overloaded and we just need to retry after a delay.
Me neither. Nor how to produce this exception on the node side. 🤔 For now I've asked @dmitrii-gaico to check on his Daedalus instance where the issue was happening for him with cardano-wallet replaced on his Daedalus with the one from this PR (https://hydra.iohk.io/job/Cardano/cardano-wallet-pr-3053/cardano-wallet-macos64/). 🙏 |
|
bors r+ |
rvl
approved these changes
Dec 15, 2021
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number
ADP-1301
Overview
This pull request fixes an issue where a wallet would lose the connection to its local node due to a
MuxSDUReadTimeout.Details
A
MuxSDUReadTimeoutorMuxSDUWriteTimeoutis thrown when the bandwidth of the node-to-client inter-process communication (IPC) has deteriorated unexpectedly. Specifially, the ouroboros-network code will close the IPC socket if it did not yield data after a 30 second timeout (sduTimeout).Chances are that the system is just overloaded and wasn't able to handle the data going through the socket connection in a timely manner. It make sense for the wallet to reconnect its local node after a delay. To give the system a chance to catch up, it also seems reasonable to choose this delay to be of the same order of magnitude as the original timeout; here we specifically choose 30 seconds.
Comments
As the issue likely involves system overload, I do not know how to test this in an automated fashion.