Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prop_balanceTx suggestions #3052

Conversation

sevanspowell
Copy link
Contributor

@sevanspowell sevanspowell commented Dec 10, 2021

Suggestions for #2996. So far, I have:

  • Changed TxUpdate to use a more descriptive type for the fee update. I hope this helps to remove ambiguity. It has the side effect of removing a HLint skip annotation.

Issue Number

ADP-1214

- Make the semantics of "Maybe Coin" more obvious by using a descriptive data
type.
@sevanspowell sevanspowell marked this pull request as ready for review December 10, 2021 06:36
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair!

@Anviking Anviking merged commit be1981e into anviking/ADP-1214/prop_balanceTx Dec 10, 2021
@Anviking Anviking deleted the sevanspowell/adp-1214/prop_balanceTx-suggestions branch December 10, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants