-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make restore benchmark slimmer #3051
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
force-pushed
the
anviking/fix-benchmarks
branch
from
December 10, 2021 18:18
ed296fa
to
3d1abe5
Compare
- To avoid timeouts, remove as much of the benchmarks we can. - Lower restore bench ownership by factor of 10
Anviking
force-pushed
the
anviking/fix-benchmarks
branch
from
December 10, 2021 20:31
f4f4bf2
to
13682a7
Compare
piotr-iohk
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 14, 2021
3051: Make restore benchmark slimmer r=Anviking a=Anviking To avoid timeouts, remove as much of the benchmarks we can. ### Comments Let's see if this works: - 0.1% https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1177 🔴 - 0.01% (name in logs wrong; later fixed) https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1179 🟢 - 0.01% https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1181#98793ee0-8d3d-4f88-a924-f314069ba47b 🟢 - [x] TODO: Seems the percentages are shown in scientific notation in the file names now. Should fix `showPercentageAsPermyriad` cc `@piotr-iohk` ### Issue Number Don't think there is one. <!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles. Note: Jira issues of the form ADP- will be auto-linked. --> Co-authored-by: Johannes Lund <[email protected]>
Build failed:
|
bors r+ |
Build succeeded: |
1 task
iohk-bors bot
added a commit
that referenced
this pull request
Dec 21, 2021
3061: Turn on heap profile in restoration benchmarks r=piotr-iohk a=piotr-iohk - [x] I have turned on heap profile plot in restoration benchmark ### Comments Hopefully it will work now with slimmer benchmarks. Testing: https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1188 🟢 👈 it works! ### Issue Number Follow up to #3051 / ADP-1307. Co-authored-by: Piotr Stachyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid timeouts, remove as much of the benchmarks we can.
Comments
Let's see if this works:
showPercentageAsPermyriad
cc @piotr-iohk
Issue Number
Don't think there is one.