Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make restore benchmark slimmer #3051

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Make restore benchmark slimmer #3051

merged 2 commits into from
Dec 14, 2021

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Dec 9, 2021

To avoid timeouts, remove as much of the benchmarks we can.

Comments

Let's see if this works:

cc @piotr-iohk

Issue Number

Don't think there is one.

@Anviking Anviking self-assigned this Dec 9, 2021
@Anviking Anviking marked this pull request as draft December 9, 2021 12:28
@Anviking Anviking force-pushed the anviking/fix-benchmarks branch from ed296fa to 3d1abe5 Compare December 10, 2021 18:18
@Anviking Anviking marked this pull request as ready for review December 10, 2021 18:18
- To avoid timeouts, remove as much of the benchmarks we can.
- Lower restore bench ownership by factor of 10
@Anviking Anviking force-pushed the anviking/fix-benchmarks branch from f4f4bf2 to 13682a7 Compare December 10, 2021 20:31
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Anviking
Copy link
Member Author

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 14, 2021
3051: Make restore benchmark slimmer r=Anviking a=Anviking

To avoid timeouts, remove as much of the benchmarks we can.

### Comments

Let's see if this works:
- 0.1% https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1177 🔴 
- 0.01% (name in logs wrong; later fixed) https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1179 🟢 
- 0.01% https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1181#98793ee0-8d3d-4f88-a924-f314069ba47b 🟢 

- [x] TODO: Seems the percentages are shown in scientific notation in the file names now. Should fix `showPercentageAsPermyriad`

cc `@piotr-iohk` 

### Issue Number

Don't think there is one.

<!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles.
  Note: Jira issues of the form ADP- will be auto-linked. -->


Co-authored-by: Johannes Lund <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 14, 2021

Build failed:

src/Test/Integration/Scenario/CLI/Shelley/Transactions.hs:392:59:
--
  | 1) CLI Specifications, SHELLEY_CLI_TRANSACTIONS, TRANS_ESTIMATE_09 - Invalid amount, string with diacritics
  | uncaught exception: IOException of type ResourceVanished
  | fd:130: hFlush: resource vanished (Broken pipe)

#2855

@Anviking
Copy link
Member Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 14, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit eeeb3f9 into master Dec 14, 2021
@iohk-bors iohk-bors bot deleted the anviking/fix-benchmarks branch December 14, 2021 23:24
iohk-bors bot added a commit that referenced this pull request Dec 21, 2021
3061: Turn on heap profile in restoration benchmarks r=piotr-iohk a=piotr-iohk

- [x] I have turned on heap profile plot in restoration benchmark

### Comments

Hopefully it will work now with slimmer benchmarks. 

Testing: https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1188 🟢  👈  it works!

### Issue Number

Follow up to #3051 / ADP-1307.


Co-authored-by: Piotr Stachyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants