Bump cardano-node to 1.32.1 #3050

rvl · 2021-12-09T11:58:31Z

Updates to cardano-node 1.32.1

Release notes for 1.31.0.

Updates cardano-node version in stack.yaml.
Updates cardano-node version in cabal.project.
Fix new build errors.
Fix any test failures.
Update readme.

Comments

Hydra jobset

Issue Number

ADP-1266

rvl · 2021-12-09T17:10:48Z

bors r+

iohk-bors · 2021-12-09T17:10:50Z

👎 Rejected by too few approved reviews

rvl · 2021-12-09T17:28:12Z

bors try

iohk-bors · 2021-12-09T17:35:08Z

try

Build failed:

ci/hydra-build:required

rvl · 2021-12-14T07:34:51Z

bors try

iohk-bors · 2021-12-14T08:20:59Z

try

Build succeeded:

Anviking

Great! lgtm modulo three comments which I think should be addressed.

Anviking · 2021-12-14T12:25:44Z

lib/core/src/Cardano/Api/Gen.hs

-    (Large mem) <- arbitrary
-    pure $ ExecutionUnits steps mem
+    (Large (steps :: Int)) <- arbitrary
+    (Large (mem :: Int)) <- arbitrary


Using Word64 might be the safer choice to preserve the previous behaviour. (ExecuionUnits had Word64 fields on 1.30.1)

Yes - fixed.

Anviking · 2021-12-14T12:31:06Z

lib/core/src/Cardano/Api/Gen.hs

        Just supported -> oneof
-            [ pure TxOutDatumHashNone
+            [ pure TxOutDatumNone
            , TxOutDatumHash supported <$> genHashScriptData


Interesting, it seems there's both TxOutDatum' and TxOutDatumHash now.

Could we rename genTxOutDatumHash to genTxOutDatum and also generate TxOutDatum'?

Or at the least add a note about it.

I renamed genTxOutDatumHash to genTxOutDatum, but where is this TxOutDatum' ?

https://github.com/input-output-hk/cardano-node/blob/4f65fb9a27aa7e3a1873ab4211e412af780a3648/cardano-api/src/Cardano/Api/TxBody.hs#L1136-L1143

I think a note would be good

Anviking · 2021-12-14T12:34:33Z

lib/shelley/src/Cardano/Wallet/Shelley/Compatibility.hs

-    { executionSteps = steps
-    , executionMemory = mem
+    { executionSteps = fromIntegral steps
+    , executionMemory = fromIntegral mem


This looks like an unsafe Natural to Word64 conversion.

I believe this is something we really don't want to overflow (even if it's impossible or has no effect at the moment).

Can we change W.ExecutionUnits to also use Natural instead of Word64?

Yes, definitely.

Anviking · 2021-12-14T12:48:54Z

Also don't forget to update the readme compatibility table!

Anviking · 2021-12-14T22:38:27Z

I rebased, some build error remains though

rvl · 2021-12-15T13:10:33Z

Thanks ... but you may have accidentally force pushed over some commits 😁. I have pushed them back now, and will address your review comments shortly.

Anviking · 2021-12-15T13:42:38Z

but you may have accidentally force pushed over some commits 😁. I have pushed them back now

🙈 👍

rvl · 2021-12-15T13:49:13Z

bors r+

3050: Bump cardano-node to 1.32.1 r=rvl a=rvl Updates to [cardano-node 1.32.1](https://github.com/input-output-hk/cardano-node/releases/tag/1.32.1) Release notes for [1.31.0](https://github.com/input-output-hk/cardano-node/releases/tag/1.31.0). - [x] Updates cardano-node version in `stack.yaml`. - [x] Updates cardano-node version in `cabal.project`. - [x] Fix new build errors. - [x] Fix any test failures. - [x] Update readme. ### Comments - [Hydra jobset](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-3050) See also: #3023 #3038 ### Issue Number ADP-1266 Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Jann Müller <[email protected]>

iohk-bors · 2021-12-15T15:02:58Z

Build failed:

buildkite/cardano-wallet

src/Test/Integration/Scenario/CLI/Shelley/Transactions.hs:244:59:
--
  | 1) CLI Specifications, SHELLEY_CLI_TRANSACTIONS, TRANS_CREATE_06 - Invalid amount, 1.5
  | uncaught exception: IOException of type ResourceVanished
  | fd:144: hFlush: resource vanished (Broken pipe)

#2500

Anviking · 2021-12-15T15:07:06Z

bors r+

iohk-bors · 2021-12-15T16:23:36Z

Merge conflict.

rvl · 2021-12-15T16:39:18Z

bors r+

iohk-bors · 2021-12-15T17:57:17Z

Build succeeded:

rvl self-assigned this Dec 9, 2021

rvl force-pushed the rvl/adp-1266/cardano-node-1.32.1 branch from a560d27 to e4ee513 Compare December 9, 2021 17:08

iohk-bors bot added a commit that referenced this pull request Dec 9, 2021

Try #3050:

12998f7

rvl force-pushed the rvl/adp-1266/cardano-node-1.32.1 branch from e4ee513 to 308a7fe Compare December 14, 2021 06:35

iohk-bors bot added a commit that referenced this pull request Dec 14, 2021

Try #3050:

3b9b884

Anviking approved these changes Dec 14, 2021

View reviewed changes

kk-hainq mentioned this pull request Dec 14, 2021

Update dependencies #3038

Closed

Anviking force-pushed the rvl/adp-1266/cardano-node-1.32.1 branch from ee17530 to 93b934b Compare December 14, 2021 22:35

rvl force-pushed the rvl/adp-1266/cardano-node-1.32.1 branch from 93b934b to 5bbf2bd Compare December 15, 2021 13:10

rvl force-pushed the rvl/adp-1266/cardano-node-1.32.1 branch from cd8367f to e2fcd53 Compare December 15, 2021 13:23

rvl force-pushed the rvl/adp-1266/cardano-node-1.32.1 branch from adcd22b to 8a133b9 Compare December 15, 2021 13:47

rvl mentioned this pull request Dec 15, 2021

Bump version from 2021.11.11 to 2021.12.15 #3062

Merged

rvl added 3 commits December 16, 2021 00:34

cabal.project: Bump cardano-node to 1.32.1

52423c9

stack.yaml: Bump cardano-node to 1.32.1

7983443

Regenerate nix

3f0be13

j-mueller and others added 5 commits December 16, 2021 00:37

Cardano API Updates

fe9ce63

More API churn

4f6aa9c

tests: cardano-cli --tx-out now uses hex for AssetName

4a2922b

README.md: Update compatibility table

68a8864

Review rework

6dacb51

rvl force-pushed the rvl/adp-1266/cardano-node-1.32.1 branch from 8a133b9 to 6dacb51 Compare December 15, 2021 16:39

iohk-bors bot merged commit 7695502 into master Dec 15, 2021

iohk-bors bot deleted the rvl/adp-1266/cardano-node-1.32.1 branch December 15, 2021 17:57

kk-hainq mentioned this pull request Dec 15, 2021

Bump cardano-wallet to upstream HEAD IntersectMBO/plutus-apps#200

Closed

8 tasks

rvl mentioned this pull request Dec 16, 2021

Fix plutus #3023

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump cardano-node to 1.32.1 #3050

Bump cardano-node to 1.32.1 #3050

rvl commented Dec 9, 2021 •

edited

Loading

rvl commented Dec 9, 2021

iohk-bors bot commented Dec 9, 2021

rvl commented Dec 9, 2021

iohk-bors bot commented Dec 9, 2021

rvl commented Dec 14, 2021

iohk-bors bot commented Dec 14, 2021

Anviking left a comment

Anviking Dec 14, 2021

rvl Dec 15, 2021

Anviking Dec 14, 2021 •

edited

Loading

rvl Dec 15, 2021

Anviking Dec 15, 2021

Anviking Dec 14, 2021 •

edited

Loading

rvl Dec 15, 2021

Anviking commented Dec 14, 2021

Anviking commented Dec 14, 2021

rvl commented Dec 15, 2021

Anviking commented Dec 15, 2021

rvl commented Dec 15, 2021

iohk-bors bot commented Dec 15, 2021 •

edited by Anviking

Loading

Anviking commented Dec 15, 2021

iohk-bors bot commented Dec 15, 2021

rvl commented Dec 15, 2021

iohk-bors bot commented Dec 15, 2021

Bump cardano-node to 1.32.1 #3050

Bump cardano-node to 1.32.1 #3050

Conversation

rvl commented Dec 9, 2021 • edited Loading

Comments

Issue Number

rvl commented Dec 9, 2021

iohk-bors bot commented Dec 9, 2021

rvl commented Dec 9, 2021

iohk-bors bot commented Dec 9, 2021

try

rvl commented Dec 14, 2021

iohk-bors bot commented Dec 14, 2021

try

Anviking left a comment

Choose a reason for hiding this comment

Anviking Dec 14, 2021

Choose a reason for hiding this comment

rvl Dec 15, 2021

Choose a reason for hiding this comment

Anviking Dec 14, 2021 • edited Loading

Choose a reason for hiding this comment

rvl Dec 15, 2021

Choose a reason for hiding this comment

Anviking Dec 15, 2021

Choose a reason for hiding this comment

Anviking Dec 14, 2021 • edited Loading

Choose a reason for hiding this comment

rvl Dec 15, 2021

Choose a reason for hiding this comment

Anviking commented Dec 14, 2021

Anviking commented Dec 14, 2021

rvl commented Dec 15, 2021

Anviking commented Dec 15, 2021

rvl commented Dec 15, 2021

iohk-bors bot commented Dec 15, 2021 • edited by Anviking Loading

Anviking commented Dec 15, 2021

iohk-bors bot commented Dec 15, 2021

rvl commented Dec 15, 2021

iohk-bors bot commented Dec 15, 2021

rvl commented Dec 9, 2021 •

edited

Loading

Anviking Dec 14, 2021 •

edited

Loading

Anviking Dec 14, 2021 •

edited

Loading

iohk-bors bot commented Dec 15, 2021 •

edited by Anviking

Loading