Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add genesis.yaml and instructions for how to use it #305

Merged
merged 1 commit into from
May 23, 2019
Merged

Add genesis.yaml and instructions for how to use it #305

merged 1 commit into from
May 23, 2019

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented May 22, 2019 •
edited
Loading

Issue Number

Overview

  • Added genesis.yaml which we need to re-generate the genesis block (which we already store in the repo)
  • Added instructions for how to do that + how to launch jormungandr and generate keys with jcli

Comments

Better than nothing I believe.

@Anviking Anviking requested review from akegalj and KtorZ May 22, 2019 15:23
@Anviking Anviking self-assigned this May 22, 2019
@Anviking
Copy link
Member Author

Btw, I'm not sure if this output is good

jormungandr --genesis-block block-0.bin --config node.config  --secret secret.yaml
May 22 17:33:26.547 INFO storing blockchain in '"/tmp/cardano/storage/blocks.sqlite"'
May 22 17:33:26.553 WARN no gRPC peers specified, skipping bootstrap
May 22 17:33:26.553 INFO starting task: transaction
May 22 17:33:26.553 INFO starting task: client-query
thread 'network' panicked at 'only support the full nodes for now', src/libcore/option.rs:1038:5
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
May 22 17:33:26.553 INFO starting task: network
May 22 17:33:26.554 INFO our node id: 300798503511280805734040594147789195854
May 22 17:33:26.554 INFO preparing, task: leadership
May 22 17:33:26.554 INFO starting, task: leadership
May 22 17:33:26.554 INFO starting, task: End Of Epoch Reminder, task: leadership

@akegalj
Copy link
Contributor

akegalj commented May 23, 2019 •
edited
Loading

Btw, I'm not sure if this output is good

thread 'network' panicked at 'only support the full nodes for now', src/libcore/option.rs:1038:5
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

have you tried to run with RUST_BACKTRACE=1 ?

Out of the blue, I think it should be ok as jormungandr is still wip so probably its not complete implementation yet.

The error seems to come from https://github.com/input-output-hk/jormungandr/blob/438179d5d769ea0e4c02613f703f088111e880a9/src/network/mod.rs#L80 . Seems like that will be the case if Configuration doesn't have public_address defined https://github.com/input-output-hk/jormungandr/blob/438179d5d769ea0e4c02613f703f088111e880a9/src/settings/start/network.rs#L46 .

Nicolas Di Prima:

We need to improve this.
This is pending because we want to make the public network optional for the self node release. People who are just testing don’t necessarily want the node to node protocol enabled

Ante:

how does node operate if public_network is not defined? I guess if it is defined it will connect to another peer in the network. If it is not defined, it will be stand alone node right?
so this bit is still wip and it is ok to see such output

Nicolas Di Prima:

yes, stand alone node. We are still not sure about what we want to do
I think we need to make it none optional from the config
src/setting/start/network.rs I believe

In this stage of development it is expected to see such output

akegalj
akegalj reviewed May 23, 2019
View reviewed changes
Copy link
Contributor

@akegalj akegalj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far. Some minor comments to possibly address

lib/jormungandr/test/data/jormungandr/README.md Outdated
@@ -0,0 +1,24 @@
You will need `jcli` and `jormungandr` from https://github.com/input-output-hk/jormungand://github.com/input-output-hk/jormungandr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a broken link, you pasted it twice concatinated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be https://github.com/input-output-hk/jormungandr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

lib/jormungandr/test/data/jormungandr/genesis.yaml
# of the blockchain that cannot be changed once the blockchain
# is started.
blockchain_configuration:
peer_2_peer: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess in this stage we won't have peer_2_peer enabled, but only standalone node

I am still not sure in which state rust node is atm but according to conversation with Nicolas #305 (comment) I would assume we should either:

  • set peer_2_peer to false and run as a standalone node
  • set peer_2_peer to true and connect to the network - but according to what Nicolas said this requires some node configuration to be changed

Also - don't take my word for it as I am just starting to use the node

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm

lib/jormungandr/test/data/jormungandr/genesis.yaml
# A list of Ed25519 Extended PublicKey that represents the
# BFT leaders encoded as bech32. The order in the list matters.
consensus_leader_ids:
- ed25519e_pk1xznffwqdhw3drw9yk4t99vpajcc4epq5kp205um5gkkz625xt3mqn4z3mx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware we have to setup initial leader list in bft - hm

lib/jormungandr/test/data/jormungandr/genesis.yaml
coefficient: 0
certificate: 0

kes_update_speed: 16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kes stands for?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@KtorZ KtorZ force-pushed the anviking/jcli-guide branch from b23cc60 to ffed9ce Compare May 23, 2019 12:16
@Anviking
Copy link
Member Author

Thanks @akegalj @KtorZ

@KtorZ KtorZ merged commit 1646d70 into master May 23, 2019
@iohk-bors iohk-bors bot deleted the anviking/jcli-guide branch May 23, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akegalj akegalj akegalj left review comments

@KtorZ KtorZ KtorZ approved these changes

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anviking @akegalj @KtorZ