Improve test coverage of applyOurTxToUTxO.
#3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
force-pushed
the
jonathanknowles/adp-1039/increase-testability-of-wallet-state-transition-functions-2
branch
from
451e124 to
82f54c5
Compare
jonathanknowles
changed the title
isOurTx and applyOurTxToUTxO.applyOurTxToUTxO.
Base automatically changed from
jonathanknowles/adp-1039/increase-testability-of-wallet-state-transition-functions
to
master
December 1, 2021 08:20
This type encapsulates a pair of filter conditions for matching entities with `IsOurs`, useful in contexts where it's necessary to match two different types of entity.
This change relocates the `AllOurs` type so that it is together with other mock implementations of `IsOurs`.
jonathanknowles
force-pushed
the
jonathanknowles/adp-1039/increase-testability-of-wallet-state-transition-functions-2
branch
from
6f8f247 to
ab0f1a2
Compare
sevanspowell
approved these changes
Dec 2, 2021
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/adp-1039/increase-testability-of-wallet-state-transition-functions-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1039
Summary
This PR improves test coverage of the
applyOurTxToUTxOfunction.Background
The existing property
prop_applyOurTxToUTxO_allOurstestsapplyOurTxToUTxOin a context where all addresses and reward accounts are identified as "ours". In this context, we can assert thatapplyOurTxToUTxOreturns a an updatedUTxOset that is identical toapplyTxToUTxO.Details
This PR adds a new property
prop_applyOurTxToUTxO_someOursthat is similar to the above property, except that only someAddressandRewardAccountvalues are marked as "ours". In this context we can no longer assert any equivalence betweenapplyOurTxToUTxOandapplyTxToUTxO, but we can assert thatapplyOurTxToUTxOonly returns a result whenisOurTxreturnsTrue.