Adjust type of TokenQuantity.pred so that it is a total function.
#3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name `pred` does not have an `unsafe` prefix, which we typically use to indicate that a function is not total. But applying `pred` to `TokenQuantity 0` will cause a run-time error. This change adjusts `pred` so that it returns `Nothing` when applied to `TokenQuantity 0`.
jonathanknowles
force-pushed
the
jonathanknowles/fix-token-quantity-warts
branch
from
5fa65f5 to
f02c3f7
Compare
jonathanknowles
force-pushed
the
jonathanknowles/fix-token-quantity-warts
branch
from
f02c3f7 to
defedfd
Compare
jonathanknowles
force-pushed
the
jonathanknowles/fix-token-quantity-warts
branch
from
defedfd to
ca90935
Compare
Anviking
approved these changes
Nov 30, 2021
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 30, 2021
3039: Adjust type of `TokenQuantity.pred` so that it is a total function. r=jonathanknowles a=jonathanknowles
## Issue number
None. (Developed while working on other unrelated things.)
## Summary
This PR:
- [x] fixes `TokenQuantity.pred` so that it is a total function, returning `Nothing` when applied to `TokenQuantity 0`.
- [x] adds the function `predZero`, which returns:
- `0` when `pred` returns `Nothing`;
- `x` when `pred` returns `Just x`.
- [x] uses `predZero` to simplify various tests.
Co-authored-by: Jonathan Knowles <[email protected]>
|
Build failed: This problem was supposed to be fixed. Interesting. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number
None. (Developed while working on other unrelated things.)
Summary
This PR:
TokenQuantity.predso that it is a total function, returningNothingwhen applied toTokenQuantity 0.predZero, which returns:0whenpredreturnsNothing;xwhenpredreturnsJust x.predZeroto simplify various tests.