Less wallets in e2e tests #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2021 16:25
…'s used across the test suite
|
bors r+ |
|
Build succeeded: |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 23, 2021
3031: Fix node db cache and e2e workflow improvements r=piotr-iohk a=piotr-iohk - 5cccf82 Attempt to fix node db caching - 5356643 More granular steps in e2e workflows - 087f7a5 Use Linux workflow cache if other not available - 0d752a0 Docker workflow adjustments - e2b2ef5 update README ### Comments Improvements made here and in #3027 bring significant improvements in speed and reliability of e2e tests. Tests on MacOS and Linux used to take 2-3h overall and on Windows even up to 6h (which often led to exceeding GH actions timeout). This was mainly due to incorrect use of node db caching which caused a lot of time spend of syncing node db against testnet. Improved execution times are as follows: | Linux|MacOS|Windows|Docker| |--|--|--|--| |[1h](https://github.com/input-output-hk/cardano-wallet/actions/runs/1490250065)|[1h 6m](https://github.com/input-output-hk/cardano-wallet/actions/runs/1490370180)|[1h 31m](https://github.com/input-output-hk/cardano-wallet/actions/runs/1490442118)|[1h](https://github.com/input-output-hk/cardano-wallet/actions/runs/1493877513)| Due to node db caching, which is happening properly now on every run, node db syncing time is cut from few hours to few minutes 🎉. Majority of the remaining test suite time is still spend on syncing fixture wallets, but it is good test on it's own so there seems to be no need for further improvements. Execution times seem to be satisfactory for nightly e2e tests and also in the need for an ad-hoc e2e run. ### Issue Number ADP-1196 3032: Remove redundant imports and constraints. r=Anviking a=jonathanknowles ## Issue Number None ## Summary This PR removes some redundant imports and constraints. I collected these patches while working on other things. It seemed sensible to put them in their own PR. Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Jonathan Knowles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c3c4288
Limit nb of wallets in e2e tests
637f4ff
Migrate all funds back to fixture wallet back from target wallet that's used across the test suite
Comments
Using single target wallet for transactions in e2e tests and extending/refactoring assertions for checking balances on target and source wallets before and after transactions taking in account amounts, assets and fees. At the end of the suite all funds are migrated back to the fixture wallet which is a good test in itself.
Issue Number
ADP-1196