Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional checks for decode endpoint #3021

Merged
merged 5 commits into from
Nov 16, 2021
Merged

Additional checks for decode endpoint #3021

merged 5 commits into from
Nov 16, 2021

Conversation

piotr-iohk
Copy link
Contributor

  • 77829dc
    cardano_wallet 0.3.17

  • 4cffafd
    Add additional checks for decoded transactions (fee,amt) in e2e plutus tests

  • c4c1ea3
    Enable tests for ADP-1202

  • f549326
    Add additional checks for decoded transactions in Contruct -> Sign -> Submit tests

  • 8550f93
    cleanup

Comments

Issue Number

ADP-974

@piotr-iohk piotr-iohk self-assigned this Nov 15, 2021
paweljakubas
paweljakubas approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 16, 2021
@iohk-bors
Merge #3021
741d262 
3021: Additional checks for decode endpoint r=piotr-iohk a=piotr-iohk

- 77829dc
  cardano_wallet 0.3.17
  
- 4cffafd
  Add additional checks for decoded transactions (fee,amt) in e2e plutus tests
  
- c4c1ea3
  Enable tests for ADP-1202
  
- f549326
  Add additional checks for decoded transactions in Contruct -> Sign -> Submit tests
  
- 8550f93
  cleanup

### Comments

<!-- Additional comments, links, or screenshots to attach, if any. -->

### Issue Number

ADP-974


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 16, 2021 •
edited by Anviking
Loading

Build failed:

src/Test/Integration/Scenario/CLI/Shelley/Transactions.hs:243:59:
--
  | 1) CLI Specifications, SHELLEY_CLI_TRANSACTIONS, TRANS_CREATE_06 - Invalid amount, string with diacritics
  | uncaught exception: IOException of type ResourceVanished
  | fd:108: hFlush: resource vanished (Broken pipe)

#2500

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 16, 2021
@iohk-bors
Merge #3021
7f61445 
3021: Additional checks for decode endpoint r=piotr-iohk a=piotr-iohk

- 77829dc
  cardano_wallet 0.3.17
  
- 4cffafd
  Add additional checks for decoded transactions (fee,amt) in e2e plutus tests
  
- c4c1ea3
  Enable tests for ADP-1202
  
- f549326
  Add additional checks for decoded transactions in Contruct -> Sign -> Submit tests
  
- 8550f93
  cleanup

### Comments

<!-- Additional comments, links, or screenshots to attach, if any. -->

### Issue Number

ADP-974


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 16, 2021 •
edited by Anviking
Loading

Build failed:

src/Test/Integration/Scenario/CLI/Shelley/Transactions.hs:243:59:
--
  | 1) CLI Specifications, SHELLEY_CLI_TRANSACTIONS, TRANS_CREATE_06 - Invalid amount, []
  | uncaught exception: IOException of type ResourceVanished
  | fd:109: hFlush: resource vanished (Broken pipe)

#2500

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 16, 2021
@iohk-bors
Merge #3021
4924a10 
3021: Additional checks for decode endpoint r=piotr-iohk a=piotr-iohk

- 77829dc
  cardano_wallet 0.3.17
  
- 4cffafd
  Add additional checks for decoded transactions (fee,amt) in e2e plutus tests
  
- c4c1ea3
  Enable tests for ADP-1202
  
- f549326
  Add additional checks for decoded transactions in Contruct -> Sign -> Submit tests
  
- 8550f93
  cleanup

### Comments

<!-- Additional comments, links, or screenshots to attach, if any. -->

### Issue Number

ADP-974


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 16, 2021 •
edited by Anviking
Loading

Build failed:

src/Test/Integration/Scenario/API/Shelley/TransactionsNew.hs:1692:54:
--
  | 1) API Specifications, NEW_SHELLEY_TRANSACTIONS, Plutus scenarios, withdrawal
  | uncaught exception: ProcessHasExited
  | ProcessHasExited "cardano-cli failed: Command failed: transaction submit  Error: Error while submitting tx: ShelleyTxValidationError ShelleyBasedEraAlonzo (ApplyTxError [DelegsFailure (DelplFailure (DelegFailure (StakeKeyAlreadyRegisteredDELEG (ScriptHashObj (ScriptHash \"1b8374d0b294a4a3399ff25f06a0707b16214f1e9b67cf89ba2454a6\")))))])\n" (ExitFailure 1)

#3057

@piotr-iohk
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 16, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit afb3402 into master Nov 16, 2021
@iohk-bors iohk-bors bot deleted the piotr/adp-974/e2e-tests branch November 16, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotr-iohk @paweljakubas