Transaction integration tests #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
commented
May 22, 2019
| ("POST", "v2/wallets/" <> widSrc <> "/transactions") | ||
| Default payload | ||
| verify r | ||
| [ expectResponseCode HTTP.status202 |
There was a problem hiding this comment.
I don't know why this request is giving me 403. Everything works fine with curl....
There was a problem hiding this comment.
you can't do multi-output transactions at the moment with those faucet wallets. That's something I wanted to enable yesterday but time flies. Since there's only a single UTxO on the faucet wallet at the moment, you can only have a single output recipient :)
We need to send more than one output on the faucet wallet and have let's say, one million ADA, but not as 1x1M, but 10x100_000 !
piotr-iohk
commented
May 22, 2019
| --post transaction | ||
| r <- request @ApiTransaction ctx ("POST", postTx wa) Default payload | ||
| verify r | ||
| [ expectResponseCode HTTP.status202 |
There was a problem hiding this comment.
Same here... 403 ¯_(ツ)_/¯
piotr-iohk
force-pushed
the
piotr/transaction_tests
branch
from
f4ada18 to
1076b8c
Compare
KtorZ
force-pushed
the
piotr/transaction_tests
branch
from
1076b8c to
b39bc4a
Compare
piotr-iohk
force-pushed
the
piotr/transaction_tests
branch
from
b39bc4a to
7a54384
Compare
piotr-iohk
force-pushed
the
piotr/transaction_tests
branch
from
7a54384 to
805def1
Compare
KtorZ
force-pushed
the
piotr/transaction_tests
branch
from
805def1 to
2cbf1b4
Compare
KtorZ
force-pushed
the
piotr/transaction_tests
branch
from
2cbf1b4 to
2f8ced6
Compare
…was not true .... 🤦
Fees are actually not necessarily fixed. They depend on the ix of the input picked. Since we generate all fixture wallets with an initial transaction with 1K outputs, ix can go from 0 to 999, and therefore be encoded on 1, 2 or 3 bytes. This depends on which input are assigned to which wallet. As a consequence, it is easier (and more correct) to look at a range of fees, in case inputs ix gets encoded on 1 or 3 bytes
KtorZ
force-pushed
the
piotr/transaction_tests
branch
from
2f8ced6 to
6b0e560
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Overview
Comments