Add GitHub action to auto-approve docs PRs #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
force-pushed
the
rvl/adp-1254/auto-approve-docs
branch
7 times, most recently
from
669ed9b to
9a8f09b
Compare
sevanspowell
approved these changes
Nov 9, 2021
sevanspowell
reviewed
Nov 9, 2021
| # Note that GitHub actions do not run from forked repos, so this | ||
| # will only approve PRs from branches in the main repo. | ||
| - name: 'Approve Docs' | ||
| if: "${{ steps.check.outputs.scope == 'docs' }}" |
There was a problem hiding this comment.
The output of check-scope.sh is an array, which is then assigned to steps.check.outputs.scope. So you're checking that an array is equal to a single element? What happens in that case?
There was a problem hiding this comment.
It's not an array, just a normal string.
So I want to check that there was exactly one top-level directory changed, and it was docs. This can be done with string comparison.
Your point stands, however. I realise that I was not handling multi-line strings properly when setting the output variable. I just pushed an amended commit which reworks newline handling.
rvl
force-pushed
the
rvl/adp-1254/auto-approve-docs
branch
from
9a8f09b to
6240d50
Compare
rvl
force-pushed
the
rvl/adp-1254/auto-approve-docs
branch
from
6240d50 to
768369c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CI step which looks at what changed in a PR. If it's "only" docs which changed, then the PR gets an automatic review approval.
Comments
Reviews aren't automatically dismissed if non-docs changes are added to the PR. That would require some modifications to the https://github.com/hmarr/auto-approve-action code.
Issue Number
ADP-1254