Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for bech32 on Windows e2e tests #3000

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Conversation

piotr-iohk
Copy link
Contributor

  • 21f613e
    Workaround for bech32 on Windows

Comments

Issue Number

n/a

@piotr-iohk piotr-iohk self-assigned this Nov 3, 2021
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One could use popen in order to write to the stdinput of the bech32 process directly, but I don't know how one would do that in Ruby — and it might still not work as expected on Windows. Using a temporary file works.

@Anviking
Copy link
Member

Anviking commented Nov 4, 2021

It seems bech32 strips \n here: https://github.com/input-output-hk/bech32/blob/7d3c9fb61a014069ad5dcae643dd12c9ebbeb6f3/bech32/app/Main.hs#L125

Maybe a non-workaround solution would be also removing \r\n, which I guess might be involved, e.g. using T.strip

@piotr-iohk
Copy link
Contributor Author

bors r+

@rvl rvl force-pushed the piotr/e2e/windows/fix/bech32 branch from 561af6b to 5e3d092 Compare November 15, 2021 07:29
@rvl rvl enabled auto-merge November 15, 2021 07:32
@rvl rvl merged commit 2663b47 into master Nov 15, 2021
@rvl rvl deleted the piotr/e2e/windows/fix/bech32 branch November 15, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants