Add generic n-ary product shrinking #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevanspowell
force-pushed
the
feature/generics-sop-reduce-boilerplate
branch
4 times, most recently
from
da5d94f to
8617e1e
Compare
sevanspowell
force-pushed
the
feature/generics-sop-reduce-boilerplate
branch
2 times, most recently
from
2a8756f to
795d5f3
Compare
This was referenced Nov 8, 2021
jonathanknowles
approved these changes
Nov 9, 2021
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 9, 2021
2999: Add generic n-ary product shrinking r=jonathanknowles a=sevanspowell - Translate the round-robin shrinking algorithm to work on n-ary products (types with one constructor [product types], with n constructor arguments), in the Generics.SOP universe. - Write a property to assert that the old selectionParams shrinker and the new one produce the same result. - Replace all instances of liftShrinkN with a generic alternative. See the following resource for more info on generics-sop: https://raw.githubusercontent.com/kosmikus/cufp-tutorial-2016/master/LectureNotes.pdf Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: IOHK <[email protected]> Co-authored-by: Jonathan Knowles <[email protected]>
|
Build failed: Cached failure: https://hydra.iohk.io/build/8178016/nixlog/3/tail |
- Translate the round-robin shrinking algorithm to work on n-ary products (types
with one constructor [product types], with n constructor arguments), in the
Generics.SOP universe.
- Derive an instance of Generics.SOP.Generic for SelectionParams.
- Replace shrinkSelectionParams with new version that uses generic shrinker
function ("groundRobinShrink").
- Write a property to assert that the old selectionParams shrinker and the new
one produce the same result.
Use 4n space indents for expressions. Use (4n+2) space indents for `where` clauses.
These operators allow us to define shrinkers with a syntax that is very
similar to the applicative syntax for defining generators.
For example:
```haskell
genMyRecord :: Gen MyRecord
genMyRecord = MyRecord
<$> genFoo
<*> genBar
<*> genBaz
shrinkMyRecord :: MyRecord -> [MyRecord]
shrinkMyRecord = genericRoundRobinShrink
<@> shrinkFoo
<:> shrinkBar
<:> shrinkBaz
<:> Nil
```
We give it an increased possibility of generating zero values. This increases the probability that we'll generate a minimal test record.
jonathanknowles
force-pushed
the
feature/generics-sop-reduce-boilerplate
branch
from
49eec98 to
4cb2855
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 9, 2021
2999: Add generic n-ary product shrinking r=jonathanknowles a=sevanspowell - Translate the round-robin shrinking algorithm to work on n-ary products (types with one constructor [product types], with n constructor arguments), in the Generics.SOP universe. - Write a property to assert that the old selectionParams shrinker and the new one produce the same result. - Replace all instances of liftShrinkN with a generic alternative. See the following resource for more info on generics-sop: https://raw.githubusercontent.com/kosmikus/cufp-tutorial-2016/master/LectureNotes.pdf Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: IOHK <[email protected]> Co-authored-by: Jonathan Knowles <[email protected]>
|
Build failed: Cached failure: https://hydra.iohk.io/build/8178016/nixlog/4/tail Same problem as before: |
This commit is intended to fix the following Windows build error: https://hydra.iohk.io/build/8178016/nixlog/4/tail
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 9, 2021
2999: Add generic n-ary product shrinking r=jonathanknowles a=sevanspowell - Translate the round-robin shrinking algorithm to work on n-ary products (types with one constructor [product types], with n constructor arguments), in the Generics.SOP universe. - Write a property to assert that the old selectionParams shrinker and the new one produce the same result. - Replace all instances of liftShrinkN with a generic alternative. See the following resource for more info on generics-sop: https://raw.githubusercontent.com/kosmikus/cufp-tutorial-2016/master/LectureNotes.pdf Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: IOHK <[email protected]> Co-authored-by: Jonathan Knowles <[email protected]>
|
Build failed: Cached failure... 🙄 I've restarted the failed job, and this time it passed. I'll wait for all jobs to succeed on hydra before restarting the merge. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with one constructor [product types], with n constructor arguments), in the
Generics.SOP universe.
one produce the same result.
See the following resource for more info on generics-sop: https://raw.githubusercontent.com/kosmikus/cufp-tutorial-2016/master/LectureNotes.pdf