Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifications to decode tx endpoint #2995

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Simplifications to decode tx endpoint #2995

merged 2 commits into from
Nov 2, 2021

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Nov 1, 2021 •
edited
Loading

  • Remove distinction between amount and amount_incoming
  • Simplify lookupTx{Ins,Outs} using isOurs

Comments

In response to #2977

Issue Number

ADP-974

@Anviking
Simplify lookupTx{Ins,Outs} using isOurs
5bd95de 
This commit does sacrifice the distinction between amount and
amount_incoming. The next commit addresses that.
@Anviking
Remove distinction between amount and amount_incoming
32df762
@Anviking Anviking self-assigned this Nov 1, 2021
@Anviking
Copy link
Member Author

Anviking commented Nov 2, 2021

bors try

iohk-bors bot added a commit that referenced this pull request Nov 2, 2021
@iohk-bors
Try #2995:
cf723b7
@Anviking Anviking merged commit c053e24 into paweljakubas/adp-974/display-serialised-tx-endpoint Nov 2, 2021
@Anviking Anviking deleted the anviking/adp-974/simplify branch November 2, 2021 10:39
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 2, 2021

try

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Anviking