Verify coin selection balancing errors. #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use these functions to make several verification functions more concise.
Use this function to make several verification functions more concise.
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/test-coin-selection-11
branch
2 times, most recently
from
ae4cb23 to
6bea6b8
Compare
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/test-coin-selection-11
branch
from
6bea6b8 to
98bdb29
Compare
jonathanknowles
changed the title
jonathanknowles
changed the title
| -- | ||
| resultWithMinimalConstraints :: Either SelectionError Selection | ||
| resultWithMinimalConstraints = | ||
| runIdentity $ runExceptT $ performSelection cs' ps |
There was a problem hiding this comment.
Suggested change
| runIdentity $ runExceptT $ performSelection cs' ps | |
| -- By using our Identity instance of MonadRandom, we always generate the | |
| -- same number. This means we'll always pick the same numbered entry in | |
| -- our UTxO set. This isn't an issue however, because when we select | |
| -- elements from the UTxO set, we remove them, so we won't always select | |
| -- the same input. | |
| runIdentity $ runExceptT $ performSelection cs' ps |
What do you think of this?
There was a problem hiding this comment.
It's an excellent suggestion: I'll add it in!
There was a problem hiding this comment.
Fixed in 7e8aced.
sevanspowell
approved these changes
Oct 28, 2021
In response to review feedback: #2993 (comment)
We move main types to the top of the module, so that they appear right next to the `performSelection` function.
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/adp-1037/test-coin-selection-11
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1037
Summary
This PR finalizes the verification of selection balancing errors returned from
CoinSelection.performSelection.Details
This PR:
EmptyUTxO.BalanceInsufficientError.InsufficientMinCoinValueError.UnableToConstructChangeError.