Add verification of CoinSelection output errors.
#2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only offering views on the output (which are difficult to test, because information has been lost), include the output itself. This will allow us to more easily verify that errors are correct.
For some reason, the names of the constructors have diverged. This commit makes them consistent again.
We don't need to pattern match on different types of failures: we only need to be able to pretty-print any failures that occur. Therefore, we can remove the outer algebraic types, which are just boilerplate, and generalize the way in which we represent verification failures.
Use of the `RecordWildCards` extension can lead to less readable code, since it becomes harder for a reader to determine which fields have been "absorbed" into a record value at the point of construction. However, in the case of the post-condition verification functions affected by this commit, it's relatively easy to tell which fields are picked up, as the definition of each failure is always next to the function that fails. Therefore, we can safely use `RecordWildCards` to remove a bit of verbosity.
jonathanknowles
changed the title
CoinSelection.
jonathanknowles
changed the title
CoinSelection.CoinSelection.
jonathanknowles
changed the title
CoinSelection.CoinSelection output errors.
sevanspowell
approved these changes
Oct 27, 2021
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/adp-1037/test-coin-selection-10
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1037
Summary
This PR:
SelectionOutputSizeExceedsLimitError.SelectionOutputTokenQuantityExceedsLimitError.