Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Descriptive Errors (Part 2/2) #299

Merged
merged 4 commits into from
May 22, 2019
Merged

More Descriptive Errors (Part 2/2) #299

merged 4 commits into from
May 22, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented May 21, 2019 •
edited
Loading

Issue Number

#260

Overview

  • I have created a small middleware to remap raw servant responses that are sent by servant before reaching our application layer.
  • I have used / mounted the aforementioned middleware
  • I have provided more extensive error messages in case of failures directly handled by servant (wrong endpoint, invalid media types, etc ...)

Comments

⚠️ base branch is KtorZ/260/more-descriptive-errors ⚠️

@KtorZ KtorZ requested a review from jonathanknowles May 21, 2019 15:25
@KtorZ KtorZ self-assigned this May 21, 2019
@piotr-iohk piotr-iohk mentioned this pull request May 21, 2019
Closed
2 tasks
@KtorZ KtorZ force-pushed the KtorZ/260/more-descriptive-errors-part2 branch from a70c4ef to 4c054e7 Compare May 22, 2019 10:37
@KtorZ KtorZ force-pushed the KtorZ/260/more-descriptive-errors branch from 726f969 to 04ec30f Compare May 22, 2019 10:38
@KtorZ KtorZ merged commit 6223bce into KtorZ/260/more-descriptive-errors May 22, 2019
@KtorZ KtorZ deleted the KtorZ/260/more-descriptive-errors-part2 branch May 22, 2019 11:44
@piotr-iohk piotr-iohk mentioned this pull request May 28, 2019
Closed
opt9 pushed a commit to opt9/cardano-sl that referenced this pull request Dec 16, 2019
@iohk-bors @Anviking
Merge input-output-hk#4064
6b73254 
4064: Preserve query and fragment part of the URI while redirecting for relative paths (swagger doc) r=KtorZ a=Anviking

## Description

<!--- A brief description of this PR and the problem is trying to solve -->

Ported from cardano-wallet c49e93a350e8294a380385258b9232df2d00ac20 to
- lib/src/Pos/Util/Swagger.hs (for the node monitoring api docs)
- wallet/src/Cardano/Wallet/API/V1/Swagger.hs (for the wallet docs)

### Todo:
- [x] Update changelog
- [x] Fill in QA

## Linked issue

cardano-foundation/cardano-wallet#299



Co-authored-by: Johannes Lund <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanknowles jonathanknowles Awaiting requested review from jonathanknowles

Assignees

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KtorZ