Add integration tests for error messages from balance endpoint #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
force-pushed
the
piotr/balance-ep/error-message
branch
from
e53e75c to
5f778f0
Compare
piotr-iohk
commented
Oct 29, 2021
| , expectErrorMessage errMsg403Fee | ||
| ] | ||
|
|
||
| it "TRANS_NEW_BALANCE_02c - Cannot balance on when I cannot afford collateral" $ \ctx -> runResourceT $ do |
There was a problem hiding this comment.
Possibly ADP-1241 case @jonathanknowles.
There was a problem hiding this comment.
@piotr-iohk I've prepared some enhancements to this test in the following branch:
https://github.com/input-output-hk/cardano-wallet/compare/jonathanknowles/adp-1225/test-enhancements
Will make this into a PR tomorrow morning!
There was a problem hiding this comment.
Update, I've added these commits to this PR.
jonathanknowles
force-pushed
the
piotr/balance-ep/error-message
branch
from
5f778f0 to
82e025c
Compare
We: - sort the largest available combination of pure ada entries into ascending order, which eases testing. - use a more natural list format, which adds a space after the comma (to make the output more readable).
This will allow us to test the output of a failed collateral selection where the largest available combination of pure ada UTxOs has more than one entry.
It's important to test the variable parts of this error so that we we can verify that the user is being presented with sensible advice. It's also important to verify the numerical values as a sanity check that they are sensible. Note that our property tests all use simulated cost models, so it's doubly important to have /something/ in the integration test suite to act as a check for sensible values.
This is to account for recent fixes to the fee calculation logic within the `balanceTransaction` function, in particular: #2989
jonathanknowles
changed the title
We expect to improve these errors in a future PR.
jonathanknowles
force-pushed
the
piotr/balance-ep/error-message
branch
from
82e025c to
83fcca6
Compare
jonathanknowles
approved these changes
Nov 8, 2021
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1241
ADP-1225
Comments
This PR adds: