Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage of failure modes for performSelection. #2986

Merged
merged 3 commits into from
Oct 22, 2021

Conversation

jonathanknowles
Copy link
Contributor

@jonathanknowles jonathanknowles commented Oct 21, 2021

Issue Number

ADP-1037

Summary

This PR:

  • adjusts genOutputsToCover so that it occasionally generates outputs with token quantities that exceed the maximum allowable token quantity (maxBound :: Word64).
  • adjusts genUTxOAvailableForInputs so that it occasionally generates UTxO sets that are completely empty.
  • rebalances the minimum coverage requirements for failure modes of performSelection.

@jonathanknowles jonathanknowles force-pushed the jonathanknowles/adp-1037/test-coin-selection-8 branch from aa31547 to 927d409 Compare October 21, 2021 05:34
@jonathanknowles jonathanknowles changed the title Add coverage for SelectionOutputTokenQuantityExceedsLimit. Improve coverage of failure modes for performSelection. Oct 21, 2021
@jonathanknowles jonathanknowles self-assigned this Oct 21, 2021
@jonathanknowles
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Oct 21, 2021
2986: Improve coverage of failure modes for `performSelection`. r=jonathanknowles a=jonathanknowles

## Issue Number

ADP-1037

## Summary

This PR:
- adjusts `genOutputsToCover` so that it occasionally generates outputs with token quantities that exceed the maximum allowable token quantity (`maxBound :: Word64`).
- adjusts `genUTxOAvailableForInputs` so that it occasionally generates UTxO sets that are completely empty.
- rebalances the minimum coverage requirements for failure modes of `performSelection`.

Co-authored-by: Jonathan Knowles <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 21, 2021

Build failed:

Cached failure

@jonathanknowles jonathanknowles force-pushed the jonathanknowles/adp-1037/test-coin-selection-8 branch from 927d409 to 72f39ee Compare October 21, 2021 06:50
@jonathanknowles
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Oct 21, 2021
2986: Improve coverage of failure modes for `performSelection`. r=jonathanknowles a=jonathanknowles

## Issue Number

ADP-1037

## Summary

This PR:
- adjusts `genOutputsToCover` so that it occasionally generates outputs with token quantities that exceed the maximum allowable token quantity (`maxBound :: Word64`).
- adjusts `genUTxOAvailableForInputs` so that it occasionally generates UTxO sets that are completely empty.
- rebalances the minimum coverage requirements for failure modes of `performSelection`.

Co-authored-by: Jonathan Knowles <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 21, 2021

Build failed:

Another cached failure...

This commit adjusts `genOutputsToCover` so that it occasionally
generates outputs with token quantities that exceed the maximum
allowable token quantity.
This commit adjusts `genUTxOAvailableForInputs` so that it occasionally
generates UTxO sets that are completely empty.
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/adp-1037/test-coin-selection-8 branch from 72f39ee to aece916 Compare October 22, 2021 01:38
@jonathanknowles
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 22, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit c0bb1fd into master Oct 22, 2021
@iohk-bors iohk-bors bot deleted the jonathanknowles/adp-1037/test-coin-selection-8 branch October 22, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants