-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve coverage of failure modes for performSelection
.
#2986
Merged
iohk-bors
merged 3 commits into
master
from
jonathanknowles/adp-1037/test-coin-selection-8
Oct 22, 2021
Merged
Improve coverage of failure modes for performSelection
.
#2986
iohk-bors
merged 3 commits into
master
from
jonathanknowles/adp-1037/test-coin-selection-8
Oct 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/test-coin-selection-8
branch
from
October 21, 2021 05:34
aa31547
to
927d409
Compare
jonathanknowles
changed the title
Add coverage for
Improve coverage of failure modes for Oct 21, 2021
SelectionOutputTokenQuantityExceedsLimit
.performSelection
.
sevanspowell
approved these changes
Oct 21, 2021
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 21, 2021
2986: Improve coverage of failure modes for `performSelection`. r=jonathanknowles a=jonathanknowles ## Issue Number ADP-1037 ## Summary This PR: - adjusts `genOutputsToCover` so that it occasionally generates outputs with token quantities that exceed the maximum allowable token quantity (`maxBound :: Word64`). - adjusts `genUTxOAvailableForInputs` so that it occasionally generates UTxO sets that are completely empty. - rebalances the minimum coverage requirements for failure modes of `performSelection`. Co-authored-by: Jonathan Knowles <[email protected]>
Build failed: Cached failure |
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/test-coin-selection-8
branch
from
October 21, 2021 06:50
927d409
to
72f39ee
Compare
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 21, 2021
2986: Improve coverage of failure modes for `performSelection`. r=jonathanknowles a=jonathanknowles ## Issue Number ADP-1037 ## Summary This PR: - adjusts `genOutputsToCover` so that it occasionally generates outputs with token quantities that exceed the maximum allowable token quantity (`maxBound :: Word64`). - adjusts `genUTxOAvailableForInputs` so that it occasionally generates UTxO sets that are completely empty. - rebalances the minimum coverage requirements for failure modes of `performSelection`. Co-authored-by: Jonathan Knowles <[email protected]>
Build failed: Another cached failure... |
This commit adjusts `genOutputsToCover` so that it occasionally generates outputs with token quantities that exceed the maximum allowable token quantity.
This commit adjusts `genUTxOAvailableForInputs` so that it occasionally generates UTxO sets that are completely empty.
jonathanknowles
force-pushed
the
jonathanknowles/adp-1037/test-coin-selection-8
branch
from
October 22, 2021 01:38
72f39ee
to
aece916
Compare
bors r+ |
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/adp-1037/test-coin-selection-8
branch
October 22, 2021 02:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1037
Summary
This PR:
genOutputsToCover
so that it occasionally generates outputs with token quantities that exceed the maximum allowable token quantity (maxBound :: Word64
).genUTxOAvailableForInputs
so that it occasionally generates UTxO sets that are completely empty.performSelection
.