Add Cardano.Api.Tx generators #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevanspowell
force-pushed
the
feature/adp-1147-tx-gen
branch
8 times, most recently
from
be8a161 to
a1a28cd
Compare
rvl
force-pushed
the
feature/adp-1147-tx-gen
branch
from
65ec3d4 to
bb9ef33
Compare
|
@sevanspowell I have rebased this onto latest master. |
Thank you! |
sevanspowell
force-pushed
the
feature/adp-1147-tx-gen
branch
2 times, most recently
from
74ee8cb to
27efd39
Compare
1 task
rvl
approved these changes
Oct 27, 2021
Comment on lines
138
to
158
| describe "genTxInsCollateral" $ do | ||
| it "ByronEra" $ | ||
| property | ||
| $ forAll (genTxInsCollateral ByronEra) | ||
| $ genTxInCollateralCoverage ByronEra | ||
| it "ShelleyEra" $ | ||
| property | ||
| $ forAll (genTxInsCollateral ShelleyEra) | ||
| $ genTxInCollateralCoverage ShelleyEra | ||
| it "AllegraEra" $ | ||
| property | ||
| $ forAll (genTxInsCollateral AllegraEra) | ||
| $ genTxInCollateralCoverage AllegraEra | ||
| it "MaryEra" $ | ||
| property | ||
| $ forAll (genTxInsCollateral MaryEra) | ||
| $ genTxInCollateralCoverage MaryEra | ||
| it "AlonzoEra" $ | ||
| property | ||
| $ forAll (genTxInsCollateral AlonzoEra) | ||
| $ genTxInCollateralCoverage AlonzoEra |
There was a problem hiding this comment.
It should be possible to factor such code by using AnyCardanoEra. I put some code in the other PR - #2975 (comment).
There was a problem hiding this comment.
Thank you. I tried to to this using existential quantification but then I had issues with the era quantifier escaping it's scope (skolem error). I'll try again with AnyCardanoEra.
sevanspowell
force-pushed
the
feature/adp-1147-tx-gen
branch
from
789ee49 to
620350a
Compare
Differing views on this. I will leave multiple commits for the review process and squash before bors. That way those that prefer multiple commits can review commit-by-commit, and those that don't can view the diff or squash locally. |
rvl
approved these changes
Oct 28, 2021
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 28, 2021
2985: Add Cardano.Api.Tx generators r=sevanspowell a=sevanspowell
- [ ] Copied and extended Tx generators from the cardano-api library. We were unable to import them due to issues with cabal sublibs.
- [ ] Made a first pass at providing coverage tests for as many of the generators as possible.
- Further note: I've decided to take a "best-effort" approach to providing coverage to generators. Coverage of generators is difficult, particularly for sum types and large product types. If you can see a better way of doing this, please let me know!
- Best reviewed commit-by-commit
### Issue Number
ADP-1147
Co-authored-by: Samuel Evans-Powell <[email protected]>
Co-authored-by: IOHK <[email protected]>
|
bors cancel |
- Copied and extended Tx generators from the cardano-api library. We were unable
to import them due to issues with cabal sublibs.
- Made a first pass at providing coverage tests for as many of the generators as
possible.
- NOTE: I've decided to take a "best-effort" approach to providing coverage
to generators. Coverage of generators is difficult, particularly for sum
types and large product types. If you can see a better way of doing this,
please let me know!
Co-authored-by: Rodney Lorrimar <[email protected]>
sevanspowell
force-pushed
the
feature/adp-1147-tx-gen
branch
from
8a6fdf5 to
db9553e
Compare
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied and extended Tx generators from the cardano-api library. We were unable to import them due to issues with cabal sublibs.
Made a first pass at providing coverage tests for as many of the generators as possible.
Best reviewed commit-by-commit
Issue Number
ADP-1147