Support for verifying selection errors #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the responsibility for verifying `Selection` values lies entirely with the `CoinSelection.verifySelection` function, we can simplify these properties.
This avoids a future name conflict with types of values returned by `verifySelectionError`.
We use the `verifySelectionError` function exported from module `CoinSelection`.
We now have a pair of post conditions: - For the case where creation of a selection succeeds. - For the case where creation of a selection fails.
sevanspowell
approved these changes
Oct 14, 2021
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/adp-1037/verify-selection-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1037
Summary
This PR:
SelectionError).prop_performSelection.Not included in this PR
For now, selection errors will always verify successfully with
VerifySelectionErrorSuccess.Future PRs will extend the definition of
verifySelectionError.