Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to GHC 8.10.7 #2969

Conversation

sevanspowell
Copy link
Contributor

  • I have updated haskell.nix to the latest version, in order to acquire the latest stackage LTS (18.13).
  • Update stackage LTS to 18.13.
  • Update from GHC 8.10.5 to 8.10.7.
  • Regenerate Nix expressions

Issue Number

ADP-1205

@sevanspowell sevanspowell self-assigned this Oct 12, 2021
@sevanspowell sevanspowell force-pushed the sevanspowell/adp-1037/fmt-library-nix-support branch from 6c8ac91 to 4840ce0 Compare October 12, 2021 07:52
@sevanspowell sevanspowell force-pushed the sevanspowell/adp-1205-use-ghc8107 branch from bbc2378 to 9913efb Compare October 12, 2021 08:17
@sevanspowell sevanspowell force-pushed the sevanspowell/adp-1205-use-ghc8107 branch from a1dfaed to 93ecc33 Compare October 14, 2021 00:52
- This is to overcome the following error when building cardano-config, a
dependency:

```
src/Cardano/Config/Git/Rev.hs:33:35: error:
    • Exception when trying to run compile-time code:
        git: readCreateProcessWithExitCode: posix_spawnp: failed (Undefined error: 0)
      Code: gitRevFromGit
    • In the untyped splice: $(gitRevFromGit)
   |
33 |         fromGit = T.strip (T.pack $(gitRevFromGit))
```

That is, the Template Haskell was failing to compile because it did not have git
in PATH.
- Note the repeated "buildPackages" attr. This snippet was provided by Hamish
Mackenzie, who said that it's "because git had (think it still might) a
dependency on python and that depended on gdb and as a result when cross
compiling buildPackages.git and buildPackages.buildPackages.git were subtly
different (causing cache misses). I am not sure if it is a problem with
gitMinimal but it might be."
@sevanspowell sevanspowell force-pushed the sevanspowell/adp-1205-use-ghc8107 branch from 93ecc33 to 5c7efa7 Compare October 14, 2021 01:25
@sevanspowell sevanspowell marked this pull request as ready for review October 14, 2021 01:45
@sevanspowell
Copy link
Contributor Author

I wrote a bit of a log of my experiences for next time: https://github.com/input-output-hk/cardano-wallet/wiki/Notes-from-upgrading-GHC-version

@sevanspowell
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Oct 14, 2021
2969: Upgrade to GHC 8.10.7 r=sevanspowell a=sevanspowell


- I have updated haskell.nix to the latest version, in order to acquire the latest stackage LTS (18.13).
- Update stackage LTS to 18.13.
- Update from GHC 8.10.5 to 8.10.7.
- Regenerate Nix expressions

### Issue Number

ADP-1205

Co-authored-by: Samuel Evans-Powell <[email protected]>
Co-authored-by: IOHK <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 14, 2021

Build failed:

@sevanspowell sevanspowell merged commit c826455 into sevanspowell/adp-1037/fmt-library-nix-support Oct 14, 2021
@sevanspowell sevanspowell deleted the sevanspowell/adp-1205-use-ghc8107 branch October 14, 2021 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants