-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to GHC 8.10.7 #2969
Merged
sevanspowell
merged 3 commits into
sevanspowell/adp-1037/fmt-library-nix-support
from
sevanspowell/adp-1205-use-ghc8107
Oct 14, 2021
Merged
Upgrade to GHC 8.10.7 #2969
sevanspowell
merged 3 commits into
sevanspowell/adp-1037/fmt-library-nix-support
from
sevanspowell/adp-1205-use-ghc8107
Oct 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c8ac91
to
4840ce0
Compare
bbc2378
to
9913efb
Compare
a1dfaed
to
93ecc33
Compare
- This is to overcome the following error when building cardano-config, a dependency: ``` src/Cardano/Config/Git/Rev.hs:33:35: error: • Exception when trying to run compile-time code: git: readCreateProcessWithExitCode: posix_spawnp: failed (Undefined error: 0) Code: gitRevFromGit • In the untyped splice: $(gitRevFromGit) | 33 | fromGit = T.strip (T.pack $(gitRevFromGit)) ``` That is, the Template Haskell was failing to compile because it did not have git in PATH. - Note the repeated "buildPackages" attr. This snippet was provided by Hamish Mackenzie, who said that it's "because git had (think it still might) a dependency on python and that depended on gdb and as a result when cross compiling buildPackages.git and buildPackages.buildPackages.git were subtly different (causing cache misses). I am not sure if it is a problem with gitMinimal but it might be."
93ecc33
to
5c7efa7
Compare
hamishmack
approved these changes
Oct 14, 2021
I wrote a bit of a log of my experiences for next time: https://github.com/input-output-hk/cardano-wallet/wiki/Notes-from-upgrading-GHC-version |
jonathanknowles
approved these changes
Oct 14, 2021
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 14, 2021
2969: Upgrade to GHC 8.10.7 r=sevanspowell a=sevanspowell - I have updated haskell.nix to the latest version, in order to acquire the latest stackage LTS (18.13). - Update stackage LTS to 18.13. - Update from GHC 8.10.5 to 8.10.7. - Regenerate Nix expressions ### Issue Number ADP-1205 Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: IOHK <[email protected]>
Build failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1205