Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve assertions in e2e tests for construct -> sign -> submit #2958

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Improve assertions in e2e tests for construct -> sign -> submit #2958

merged 3 commits into from
Oct 8, 2021

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Oct 7, 2021 •
edited
Loading

  • Improve assertions
  • run on CI again
  • make failing tests pending

Comments

Issue Number

sort of ADP-1202

@piotr-iohk piotr-iohk self-assigned this Oct 7, 2021
@piotr-iohk piotr-iohk force-pushed the piotr/update-sign-construct-tests branch from 9c6f136 to 4c738ef Compare October 7, 2021 15:24
paweljakubas
paweljakubas approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@piotr-iohk
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 8, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit c1630e4 into master Oct 8, 2021
@iohk-bors iohk-bors bot deleted the piotr/update-sign-construct-tests branch October 8, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotr-iohk @paweljakubas